Skip to content

bpftool: Support symbolic map creation flags

Tianyi Chen bpf linux-kselftest 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v42 patches 0 repliesSuperseded

Changes in v5 from the cover letter

- State explicitly that the old numeric parser accepted empty input as zero and could truncate or wrap out-of-range values. Rejecting those inputs is an intentional compatibility change already present in v4.
- Explain why BPF_F_PATH_FD is excluded from map creation flags.
- Point the manual to feature list_builtins map_create_flags for the accepted symbolic names and rewrap the feature documentation.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bpftool: Accept symbolic map creation flagstools/bpf/bpftool/Documentation/bpftool-feature.rst tools/bpf/bpftool/Documentation/bpftool-map.rst tools/bpf/bpftool/bash-completion/bpftool +3 more+131 -160 replies
2/2selftests/bpf: Cover symbolic bpftool map creation flagstools/testing/selftests/bpf/prog_tests/bpftool_map_flags.c+100 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH bpf-next v5 0/2] bpftool: Support symbolic map creation flags

Add comma-separated BPF_F_* names to map create flags, with matching documentation, completion and selftests.

Changes in v5:
- State explicitly that the old numeric parser accepted empty input as zero and could truncate or wrap out-of-range values. Rejecting those inputs is an intentional compatibility change already present in v4.
- Explain why BPF_F_PATH_FD is excluded from map creation flags.
- Point the manual to feature list_builtins map_create_flags for the accepted symbolic names and rewrap the feature documentation.

The parser and tests are unchanged from v4.

v4: https://lore.kernel.org/r/[email protected]
Review: https://lore.kernel.org/r/523c73e7f76e0634a3e061e76ca4c39eb21cb006fc78875ddaf6a35e38bfd500@mail.kernel.org

Validation:
- Rebuilt bpftool, its manual pages and the focused selftest runner.
- All 29 bpftool_map_flags subtests passed. The three revised series were tested together: 52 subtests passed with no skips or failures in an x86-64 KVM guest running Linux 7.3.0-rc2 from bpf/master, with LLVM 20-built BPF test objects.
- Bash syntax, bpftool synchronization checks and diff checks passed.
- The generated patches apply cleanly to current bpf-next.

This was a focused run. Unrelated selftests requiring unavailable kernel features were excluded from the build with PERMISSIVE=1.

Tianyi Chen (2):
bpftool: Accept symbolic map creation flags selftests/bpf: Cover symbolic bpftool map creation flags

 .../bpftool/Documentation/bpftool-feature.rst |  16 +--
 .../bpf/bpftool/Documentation/bpftool-map.rst |  15 ++-
 tools/bpf/bpftool/bash-completion/bpftool     |  22 +++-
 tools/bpf/bpftool/feature.c                   |   7 +-
 tools/bpf/bpftool/main.h                      |   1 +
 tools/bpf/bpftool/map.c                       |  86 ++++++++++++++-
 .../bpf/prog_tests/bpftool_map_flags.c        | 100 ++++++++++++++++++
 7 files changed, 231 insertions(+), 16 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/bpftool_map_flags.c

base-commit: af0b84a9215d951d16f26b7ee34353b970cf5d4e

Signature · 1 line
2.55.0