Skip to content

wifi: iwlwifi: fix RCU lifetime on setup failures

Zhao Li linux-wireless lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wifi: iwlwifi: mvm: defer freeing PTK PN state on key failuredrivers/net/wireless/intel/iwlwifi/mvm/mac80211.c+1 -10 replies
2/3wifi: iwlwifi: mld: defer freeing PTK PN state on key failuredrivers/net/wireless/intel/iwlwifi/mld/mac80211.c+1 -10 replies
3/3wifi: iwlwifi: mld: unpublish links before freeing on add failuredrivers/net/wireless/intel/iwlwifi/mld/link.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] wifi: iwlwifi: fix RCU lifetime on setup failures

Two key-add error paths remove packet-number state from RCU-protected pointers and then free it immediately. Concurrent RX readers can still hold the removed objects.

The MLD link-add error path has a related problem. It can free a link without first removing a restart-time published pointer, or free it immediately after unpublishing it on a later firmware failure.

Use the RCU-delayed freeing already used by the corresponding normal removal paths, and make the link mapping cleanup common to every failed link add. Keep the MVM and MLD fixes separate because their origins, objects and maintained-line exposure differ.

Zhao Li (3):
wifi: iwlwifi: mvm: defer freeing PTK PN state on key failure
wifi: iwlwifi: mld: defer freeing PTK PN state on key failure
wifi: iwlwifi: mld: unpublish links before freeing on add failure

 drivers/net/wireless/intel/iwlwifi/mld/link.c     | 4 ++--
 drivers/net/wireless/intel/iwlwifi/mld/mac80211.c | 2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

base-commit: 50d3d79dc0743b616afb00d01a626c76758721f7

Signature · 1 line
2.55.0