Skip to content

mm/damon: improve readability, clarity and test coverage

SJ Park damon linux-doc linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] docs-mm-damon-design-clarify-bp-is-basis-point.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 10 repliesApplied 10/10

Changes from RFC v2 from the cover letter

- RFC v2: https://lore.kernel.org/[email protected]
- Drop RFC tag.
- Rebase to the latest mm-new.
Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Fix a typo in the selftest warning message.
- Collect A-b: from Randy.
- Split out damos_adjust_quota() fix to an individual hotfix patch.
- Add a patch for initializing walk_control_obsolete in damon_new_ctx().
- Add a patch for probe_hits_wsum damos filter commit kunit test.
- Trivial patch sequence update.
- Rebase to the latest mm-new.

Patches in v1 All 10 applied

#Subject and filesSizeRepliesApplied
1/10mm/damon/api: remove NR_DAMOS_FILTER_TYPESinclude/linux/damon.h+0 -24 repliesApplied
2/10mm/damon/core: use abs_diff() in damon_feed_loop_next_input()mm/damon/core.c+1 -41 replyApplied
3/10mm/damon/core: use mult_frac() in damon_feed_loop_next_input()mm/damon/core.c+1 -51 replyApplied
4/10mm/damon/core: set damon_ctx->walk_control_obsolete in damon_new_ctx()mm/damon/core.c+1 -40 repliesApplied
5/10mm/damon/core: document damon_call()/damon_start() race hang issuemm/damon/core.c+3 -00 repliesApplied
6/10mm/damon/paddr: remove pa parameter from damon_pa_filter_pass()mm/damon/paddr.c+2 -30 repliesApplied
7/10mm/damon/tests/core-kunit: test eligible_mem_bp commitmentmm/damon/tests/core-kunit.h+10 -00 repliesApplied
8/10mm/damon/tests/core-kunit: add probe_hits_wsum damos filter commit testmm/damon/tests/core-kunit.h+20 -00 repliesApplied
9/10selftests/damon/sysfs_memcg_path_leak: fail only for real DAMON leaktools/testing/selftests/damon/sysfs_memcg_path_leak.sh+7 -01 replyApplied
10/10Docs/mm/damon/design: clarify bp is basis pointDocumentation/mm/damon/design.rst+3 -21 replyApplied

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchRandy DunlapAsier GutierrezZenghui Yu (Huawei)
1/10R-b
2/10R-b
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] mm/damon: improve readability, clarity and test coverage

Yet another batch of miscellaneous DAMON minor improvements. Mostly focused on readability and clarity of code and document, and unit/self test coverage. No user-visible behavioral change is intended.

Changes from RFC v2
- RFC v2: https://lore.kernel.org/[email protected]
- Drop RFC tag.
- Rebase to the latest mm-new.
Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Fix a typo in the selftest warning message.
- Collect A-b: from Randy.
- Split out damos_adjust_quota() fix to an individual hotfix patch.
- Add a patch for initializing walk_control_obsolete in damon_new_ctx().
- Add a patch for probe_hits_wsum damos filter commit kunit test.
- Trivial patch sequence update.
- Rebase to the latest mm-new.

SJ Park (10):
mm/damon/api: remove NR_DAMOS_FILTER_TYPES
mm/damon/core: use abs_diff() in damon_feed_loop_next_input() mm/damon/core: use mult_frac() in damon_feed_loop_next_input() mm/damon/core: set damon_ctx->walk_control_obsolete in damon_new_ctx() mm/damon/core: document damon_call()/damon_start() race hang issue mm/damon/paddr: remove pa parameter from damon_pa_filter_pass() mm/damon/tests/core-kunit: test eligible_mem_bp commitment mm/damon/tests/core-kunit: add probe_hits_wsum damos filter commit
test
selftests/damon/sysfs_memcg_path_leak: fail only for real DAMON leak Docs/mm/damon/design: clarify bp is basis point

 Documentation/mm/damon/design.rst             |  5 ++--
 include/linux/damon.h                         |  2 --
 mm/damon/core.c                               | 19 ++++--------
 mm/damon/paddr.c                              |  5 ++--
 mm/damon/tests/core-kunit.h                   | 30 +++++++++++++++++++
 .../selftests/damon/sysfs_memcg_path_leak.sh  |  7 +++++
 6 files changed, 48 insertions(+), 20 deletions(-)

base-commit: 942682790e570c9422a389bf34097e74c4777fe9

Signature · 1 line
2.47.3