ata: Extend Samsung LPM quirk to AMD and fix force documentation
Status from this message: Applied to libata/linux.git (for-7.3-fixes), thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ata: libata-core: Extend Samsung LPM quirk to AMD controllersdrivers/ include/ | +10 | 2 replies | |
| 2/2 | ata: libata: Correct libata.force parameter documentationDocumentation/ | +4 | 4 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Mario Limonciello (AMD) | Damien Le Moal |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] ata: Extend Samsung LPM quirk to AMD and fix force documentation
Hello,
A user reports that a Samsung SSD 870 QVO 8TB connected to an AMD 600 Series chipset SATA controller times out on STANDBY IMMEDIATE during system suspend with med_power_with_dipm enabled. The command completes with max_performance instead.
Patch 1 extends the existing Samsung LPM quirk from ATI to AMD controllers, renaming it to ATA_QUIRK_NO_LPM_ON_ATI_AND_AMD. It keeps the same drive model matches and leaves the NCQ quirk restricted to ATI. LPM behavior on other controller vendors, including Intel, is unchanged. The underlying controller/device interaction has not been root-caused.
Patch 2 separately corrects the libata.force parameter documentation:
the supported PIO range, the scope of ncqati, and the set-only behavior of max_sec_1024 and max_sec_lba48. It introduces no new force options.
Note that the ATI (and now AMD) LPM quirk never had a libata.force option, and neither do we want to add one.
If a user wants to force enable/disable lpm, they can use the existing [no]lpm libata.force parameter. We therefore do not have and documentation in kernel-parameters.txt to change.
Bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=221986
Kind regards,
Niklas
Niklas Cassel (2):
ata: libata-core: Extend Samsung LPM quirk to AMD controllers
ata: libata: Correct libata.force parameter documentation
Documentation/admin-guide/kernel-parameters.txt | 10 ++++------ drivers/ata/libata-core.c | 15 ++++++++------- include/linux/libata.h | 4 ++-- 3 files changed, 14 insertions(+), 15 deletions(-)
Signature · 1 line
2.55.0