Skip to content

scsi: target: core: Fix and convert kmap_atomic() in SBC emulation

Danish Khateeb linux-scsi lkml target-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2scsi: target: core: Fix kunmap_atomic() address in sbc_dif_copy_prot()drivers/target/target_core_sbc.c+2 -20 replies
2/2scsi: target: core: Use kmap_local_page() in SBC emulationdrivers/target/target_core_sbc.c+28 -280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] scsi: target: core: Fix and convert kmap_atomic() in SBC emulation

Patch 1 fixes the address sbc_dif_copy_prot() passes to kunmap_atomic(), which has been off by one page since v4.2. It keeps kmap_atomic() so it can be backported on its own, which is why checkpatch warns about the deprecated call there. Patch 2 then converts the kmap_atomic() calls in target_core_sbc.c to kmap_local_page().

The rd backend's protection pages are lowmem, so the bug only shows on 32-bit x86 with CONFIG_DEBUG_HIGHMEM, which gives lowmem pages a real kmap slot too. I have not Cc'd stable for that reason.

Testing, in QEMU/KVM, with PREEMPT_LAZY and DEBUG_PREEMPT:

- i386 with HIGHMEM and DEBUG_HIGHMEM. On fe2ec83746e5 (v7.3-rc4+), kunmap_local_indexed() warns from sbc_dif_copy_prot(), the log has 103 "DIFv1 checksum failed" errors, and 9 of the 23 checks fail with EILSEQ or EIO on the rd PI disk. With patch 1, and with both patches, all 23 pass with no warnings.
- x86-64 with KASAN. All 23 checks pass before and after the series, with no reports.

A static init sets up three rd_mcp devices through configfs and exports them through tcm_loop: one with pi_prot_type=1, one without PI behind a TPG with fabric_prot_type=1, and a plain one. It then runs O_DIRECT and buffered writes and read-backs on the two PI disks, SG_IO WRITE(10) and READ(10) without PI so the target inserts and strips it, and COMPARE AND WRITE with a match and with a miscompare at byte 403. Kprobes show that sbc_dif_generate(), sbc_dif_verify(), sbc_dif_copy_prot() and compare_and_write_callback(), which inlines compare_and_write_do_cmp(), all ran. W=1 and sparse are clean for target_core_sbc.c. I can post the init program if it is useful.

Danish Khateeb (2):
scsi: target: core: Fix kunmap_atomic() address in sbc_dif_copy_prot()
scsi: target: core: Use kmap_local_page() in SBC emulation

 drivers/target/target_core_sbc.c | 58 ++++++++++++++++----------------
 1 file changed, 29 insertions(+), 29 deletions(-)

base-commit: fe2ec83746e501645709761605c2464a44fd2929

Signature · 1 line
2.55.0