Skip to content

media: ipu6: ipu7 and ipu6 fw-isys fixes

David Carlier linux-media lkml stable 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- 1/3: use goto labels for error handling (Sakari)
- 2/3: new, same leak in ipu6_isys_fwcom_cfg_init() (Sakari), also check its return value
- 3/3: unchanged

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3media: ipu6: Fix ipu7 firmware context leak on stream startdrivers/media/pci/intel/ipu6/ipu7-fw-isys.c+15 -80 replies
2/3media: ipu6: Fix firmware config leak on stream startdrivers/media/pci/intel/ipu6/ipu6-fw-isys.c+24 -100 replies
3/3media: ipu6: Check the ipu7 output pin queue before completing a bufferdrivers/media/pci/intel/ipu6/ipu7-fw-isys.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] media: ipu6: ipu7 and ipu6 fw-isys fixes

Fix the firmware config leaks on every stream start in both the ipu7 and ipu6 fw-isys init paths, and a NULL dereference on a PIN_DATA_READY response for an unconfigured ipu7 output pin.

Changes in v2:
- 1/3: use goto labels for error handling (Sakari)
- 2/3: new, same leak in ipu6_isys_fwcom_cfg_init() (Sakari), also check its return value
- 3/3: unchanged

v1: https://lore.kernel.org/linux-media/[email protected]/

David Carlier (3):
media: ipu6: Fix ipu7 firmware context leak on stream start
media: ipu6: Fix firmware config leak on stream start
media: ipu6: Check the ipu7 output pin queue before completing a
buffer

 drivers/media/pci/intel/ipu6/ipu6-fw-isys.c | 34 +++++++++++++++------
 drivers/media/pci/intel/ipu6/ipu7-fw-isys.c | 26 ++++++++++------
 2 files changed, 41 insertions(+), 19 deletions(-)

base-commit: 2dcdfb625c3b8fe87454e19dfbc54b3e3f0ad70e

Signature · 1 line
2.55.0