Skip to content

Selective fetch calculation fixes

Jouni Högander intel-gfx intel-xe stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/psr: Clear selective fetch area when duplicating plane statedrivers/gpu/drm/i915/display/intel_plane.c drivers/gpu/drm/i915/display/intel_psr.c+12 -131 reply
2/8drm/i915/display: Add enabled pipe planes into state for selective fetchdrivers/gpu/drm/i915/display/intel_plane.c drivers/gpu/drm/i915/display/intel_psr.c+18 -171 reply
3/8drm/i915/psr: Disable linked plane sel fetch as welldrivers/gpu/drm/i915/display/intel_psr.c+13 -141 reply
4/8drm/i915/psr: Fix SFF and CFF CTL register bit definitionsdrivers/gpu/drm/i915/display/intel_psr_regs.h+2 -21 reply
5/8drm/i915/psr: Skip sel fetch support check for invisible planesdrivers/gpu/drm/i915/display/intel_psr.c+2 -11 reply
6/8drm/i915/psr: Don't write 0 size area into plane sel fetch area registersdrivers/gpu/drm/i915/display/skl_universal_plane.c+2 -11 reply
7/8drm/i915/psr: Remove drm_info_once on failed selective fetch areadrivers/gpu/drm/i915/display/intel_psr.c+1 -61 reply
8/8drm/i915/psr: Don't clip plane state destination rectangledrivers/gpu/drm/i915/display/intel_psr.c+11 -92 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMika Kahola
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Selective fetch calculation fixes

This set contains fixes for selective fetch area calculation.

Fixes in the set:

- Clear plane selective fetch area on plane state duplicate and keep the area consistent on full update.
- Add enabled pipe planes into the state before the plane checks to keep the UV and Y plane linking in place.
- Set the selective fetch area for the linked Y plane also when selective fetch is being disabled.
- Fix SFF_CTL and CFF_CTL register bit definitions.
- Skip the plane selective fetch support check for invisible planes.
- Don't write a zero sized area into the plane selective fetch area registers.
- Remove misleading drm_info_once on zero sized selective fetch area.
- Don't clip the cursor plane state destination rectangle when calculating the selective update area.

Jouni Högander (8):
drm/i915/psr: Clear selective fetch area when duplicating plane state drm/i915/display: Add enabled pipe planes into state for selective
fetch
drm/i915/psr: Disable linked plane sel fetch as well drm/i915/psr: Fix SFF and CFF CTL register bit definitions drm/i915/psr: Skip sel fetch support check for invisible planes drm/i915/psr: Don't write 0 size area into plane sel fetch area
registers
drm/i915/psr: Remove drm_info_once on failed selective fetch area drm/i915/psr: Don't clip plane state destination rectangle

 drivers/gpu/drm/i915/display/intel_plane.c    |  11 ++
 drivers/gpu/drm/i915/display/intel_psr.c      | 106 ++++++++----------
 drivers/gpu/drm/i915/display/intel_psr_regs.h |   4 +-
 .../drm/i915/display/skl_universal_plane.c    |   3 +-
 4 files changed, 61 insertions(+), 63 deletions(-)
Signature · 1 line
2.43.0