Skip to content

mm/memory: remove unused vmf_insert_mixed_mkwrite()

Sang-Heon Jeon linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 9 repliesIn review
  2. v11 patch 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mm/memory: remove unused vmf_insert_mixed_mkwrite()include/linux/mm.h mm/memory.c+5 -133 replies
2/3mm/memory: remove the mkwrite argument from __vm_insert_mixed()mm/memory.c+18 -393 replies
3/3mm/memory: merge __vm_insert_mixed() into vmf_insert_mixed()mm/memory.c+3 -93 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSJ ParkJose A. Perez de AzpillagaAnshuman Khandual
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] mm/memory: remove unused vmf_insert_mixed_mkwrite()

Hello,

Since commit 38607c62b34b ("fs/dax: properly refcount fs dax pages"), vmf_insert_mixed_mkwrite() has no callers. This series removes it and the mkwrite handling that only it used.

Patch 1 removes the function.

Patch 2 removes the mkwrite argument, which is then always false. It also removes the unreachable code in insert_pfn().

Patch 3 merges __vm_insert_mixed() into vmf_insert_mixed().

No functional change.

---
Changes from v1 [1]
- Split into three patches for easier review
- Move the comment about -EBUSY handling above the check in __vm_insert_mixed()

[1] https://lore.kernel.org/all/[email protected]/
---

Sang-Heon Jeon (3):
mm/memory: remove unused vmf_insert_mixed_mkwrite() mm/memory: remove the mkwrite argument from __vm_insert_mixed() mm/memory: merge __vm_insert_mixed() into vmf_insert_mixed()

 include/linux/mm.h |  2 --
 mm/memory.c        | 81 ++++++++++++++--------------------------------
 2 files changed, 24 insertions(+), 59 deletions(-)

base-commit: 1c2b8d2725f84b43fabe3b3e9628c91db8ca6c65

Signature · 1 line
2.43.0