Skip to content

pinctrl: sunxi: number the IRQ banks from the first one that has IRQs

Pablo Mazzini linux-arm-kernel linux-devicetree linux-gpio linux-sunxi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v11 patch 6 repliesSuperseded

Changes in v3 from the cover letter

- apply irq_bank_map to the A733 register layout too (Sashiko)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pinctrl: sunxi: dt: number the IRQ banks from the first one that has IRQsdrivers/pinctrl/sunxi/pinctrl-sun55i-a523.c drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c +1 more+12 -100 replies
2/3dt-bindings: pinctrl: sun55i-a523: one interrupt per implemented bankDocumentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml+4 -41 reply
3/3arm64: dts: allwinner: a523: drop the PA GPIO interruptarch/arm64/boot/dts/allwinner/sun55i-a523.dtsi+1 -20 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/3
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] pinctrl: sunxi: number the IRQ banks from the first one that has IRQs

The DT pinctrl helper numbers the IRQ banks from PA, even when PA has none. The A523 got a DT interrupt for its unimplemented PA bank to work around that, the A733 would need the same, and on both PK is written past the end of irq_array.

Number the IRQ banks like the static drivers do, with irq_bank_map for the A523 and A733, and drop the PA interrupt from the binding and the A523 DT. The B288 (IRQ banks on PB, PD, PF and PG) then needs no made-up interrupt.

v3:
- apply irq_bank_map to the A733 register layout too (Sashiko)

v2:
- give the A523 and A733 an irq_bank_map, and drop the PA interrupt from the binding and the A523 DT

Pablo Mazzini (3):
pinctrl: sunxi: dt: number the IRQ banks from the first one that has
IRQs
dt-bindings: pinctrl: sun55i-a523: one interrupt per implemented bank
arm64: dts: allwinner: a523: drop the PA GPIO interrupt

 .../bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml   | 8 ++++----
 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi            | 3 +--
 drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c               | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c               | 5 ++++-
 drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c                  | 8 +++-----
 drivers/pinctrl/sunxi/pinctrl-sunxi.h                     | 7 ++++---
 6 files changed, 17 insertions(+), 16 deletions(-)

base-commit: 4f0dbdbdb3ad122e8bbfb1d722fd584bac7124db

Signature · 1 line
2.52.0