Skip to content

soc: fsl: dpio: Fix IRQ cleanup during probe and removal

Myeonghun Pak linux-arm-kernel linuxppc-dev lkml stable 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 2 repliesApplied

Changes in v2 from the cover letter

- Present the two previously separate patches as a series.
- Remove the unnecessary unregister call from the probe error path, as suggested by Ioana Ciornei.
- Move devm_free_irq() into unregister_dpio_irq_handlers(), as suggested by Ioana Ciornei, to keep registration and unregistration in sync.
- Add Cc: [email protected] to both patches.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2soc: fsl: dpio: Fix cleanup on IRQ registration failuredrivers/soc/fsl/dpio/dpio-driver.c+2 -20 replies
2/2soc: fsl: dpio: Free the IRQ before releasing the I/O objectdrivers/soc/fsl/dpio/dpio-driver.c+3 -20 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIoana Ciornei
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] soc: fsl: dpio: Fix IRQ cleanup during probe and removal

This series fixes two DPIO I/O object lifetime issues during probe failure and device removal.

Patch 1 releases the I/O object when IRQ registration fails and removes the unnecessary unregister call from the probe error path. Patch 2 frees the managed IRQ before returning its resource to the MC pool and before releasing the I/O object during removal.

Both patches carry their respective Fixes tags and are marked for stable backporting. Patch 2 is based on patch 1, which removes the probe error path call to unregister_dpio_irq_handlers() before that helper starts freeing the managed IRQ.

Changes in v2:
- Present the two previously separate patches as a series.
- Remove the unnecessary unregister call from the probe error path, as suggested by Ioana Ciornei.
- Move devm_free_irq() into unregister_dpio_irq_handlers(), as suggested by Ioana Ciornei, to keep registration and unregistration in sync.
- Add Cc: [email protected] to both patches.

Based on Linux 7.3-rc3 (fd73f4a6659897191fa0d40695fe370925dd3780).

Myeonghun Pak (2):
soc: fsl: dpio: Fix cleanup on IRQ registration failure
soc: fsl: dpio: Free the IRQ before releasing the I/O object

 drivers/soc/fsl/dpio/dpio-driver.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
2.53.0