Skip to content

iio: proximity: Add Vishay VCNL36829 driver

Liu Yufei linux-devicetree linux-iio lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- driver: Collect Reviewed-by from Joshua Crofts and Andy Shevchenko.
- driver: Use dev_info() instead of dev_warn() for an unknown device ID (Joshua Crofts).
- driver: Wrap the write_raw() arguments on a logical boundary (Andy Shevchenko).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: iio: proximity: Add Vishay VCNL36829Documentation/devicetree/bindings/iio/proximity/vishay,vcnl36829.yaml MAINTAINERS+60 -00 replies
2/2iio: proximity: Add driver for Vishay VCNL36829MAINTAINERS drivers/iio/proximity/Kconfig drivers/iio/proximity/Makefile +1 more+311 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiJoshua CroftsAndy Shevchenko
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/2] iio: proximity: Add Vishay VCNL36829 driver

From: Liu Yufei <[email protected]>

This series adds support for the Vishay VCNL36829, an I2C proximity sensor with an integrated VCSEL emitter.

Patch 1 adds the devicetree binding.
Patch 2 adds the IIO driver, which exposes the proximity reading and a configurable integration time.

Tested on Orange Pi Zero 2W.

Changes in v3:
- driver: Collect Reviewed-by from Joshua Crofts and Andy Shevchenko.
- driver: Use dev_info() instead of dev_warn() for an unknown device ID (Joshua Crofts).
- driver: Wrap the write_raw() arguments on a logical boundary (Andy Shevchenko).

Changes in v2:
- dt-bindings: Collect Reviewed-by from Krzysztof.
- driver: Address review comments from Andy:
- Use a Datasheet: tag in the commit message.
- Drop mod_devicetable.h, sort the includes and include what is used.
- Drop the i2c_client pointer from the private data and use regmap_get_device() instead.
- Drop the unused i2c_set_clientdata().
- Enable a maple regmap cache, mark PS_DATA and DEV_ID volatile.
- Rework the integration time validation in write_raw().
- Use reverse xmas tree order for local variables.
- Document the power-up delay and use 3 * USEC_PER_MSEC.
- Warn and continue on an unknown device ID instead of failing.
- Join lines that fit within 100 columns.
- Simplify the Assisted-by tag.
- driver: Drop the i2c_check_functionality() call, as devm_regmap_init_i2c() already checks the adapter capabilities.

Link to v2: https://lore.kernel.org/linux-iio/[email protected]/
Link to v1: https://lore.kernel.org/linux-iio/[email protected]/

Liu Yufei (2):
dt-bindings: iio: proximity: Add Vishay VCNL36829
iio: proximity: Add driver for Vishay VCNL36829

 .../iio/proximity/vishay,vcnl36829.yaml       |  55 ++++
 MAINTAINERS                                   |   6 +
 drivers/iio/proximity/Kconfig                 |  11 +
 drivers/iio/proximity/Makefile                |   1 +
 drivers/iio/proximity/vcnl36829.c             | 298 ++++++++++++++++++
 5 files changed, 371 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/vishay,vcnl36829.yaml
 create mode 100644 drivers/iio/proximity/vcnl36829.c

base-commit: 52c36105f76e96b638152a42e735f2e7767ed946

Signature · 1 line
2.53.0