Skip to content

iio: enable context analysis for all drivers

Rupesh Majhi chrome-platform linux-amlogic linux-arm-kernel linux-arm-msm linux-iio lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 12 repliesIn review
  2. v31 patch 4 repliesSuperseded
  3. v21 patch 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch5 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9iio: adc: qcom-spmi-adc5-gen3: fix lock annotations on mutex helpersdrivers/iio/adc/qcom-spmi-adc5-gen3.c+2 -20 replies
2/9iio: core: annotate the conditional mode claimsinclude/linux/iio/iio.h+2 -72 replies
3/9iio: core: mark the mode lock helpers __context_unsafedrivers/iio/industrialio-core.c+2 -00 replies
4/9iio: accel: kionix-kx022a: annotate the lock helpersdrivers/iio/accel/kionix-kx022a.c+2 -01 reply
5/9iio: adc: meson_saradc: annotate the lock helpersdrivers/iio/adc/meson_saradc.c+2 -00 replies
6/9iio: buffer-dma: annotate the queue lock helpersdrivers/iio/buffer/industrialio-buffer-dma.c+2 -00 replies
7/9iio: light: opt3001: mark the interrupt handler __context_unsafedrivers/iio/light/opt3001.c+1 -00 replies
8/9iio: light: veml6031x00: annotate the event enable helpersdrivers/iio/light/veml6031x00.c+2 -01 reply
9/9iio: enable context analysis for all driversdrivers/iio/Makefile drivers/iio/accel/Makefile drivers/iio/adc/Makefile +47 more+106 -14 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchJinseob KimJavier CarrascoMatti Vaittinen
1/9
2/9
3/9
4/9R-b
5/9
6/9
7/9
8/9R-b
9/9T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/9] iio: enable context analysis for all drivers

Jonathan asked for the qcom-spmi-adc5-gen3 fix to become the first patch of a series that enables context analysis across IIO [1]. This is that series.

With CONTEXT_ANALYSIS := y in every drivers/iio Makefile, testing gives 256 warnings and 2 errors in 126 files (x86_64 allmodconfig, clang 23.1).

Patch 1 fixes the two qcom errors, as v3 did, but names the lock the way Bart suggested [2]. Patch 2 annotates the two conditional mode claims in iio.h, which accounts for 241 of the warnings, in 120 files. Patch 3 covers the core helpers behind them. Patches 4 to 8 annotate lock helpers in kx022a, meson_saradc, the DMA buffer, opt3001 and veml6031x00. None of them is a locking bug. Patch 9 enables the analysis. The common and sensorhubs Makefiles only list subdirectories and are left alone.

With the series applied all 726 files build without warnings, also with W=1. bma180, ab8500-gpadc and intel_dc_ti_adc are not in allmodconfig and were built on their own. gcc W=1 builds show no warnings. Removing an unlock or a release is still reported, tried in kx022a, ms5611 and veml6031x00.

Bart's thread-safety branch [3] has most of the same annotations. For meson_saradc and the DMA buffer he uses __context_unsafe(). Here they name the lock, so the helpers are checked, and for meson_saradc the callers too.

Written with help from an LLM coding assistant.

v4: was a single qcom patch, now the first of nine
v3: https://lore.kernel.org/linux-iio/[email protected]/

[1] https://lore.kernel.org/linux-iio/20261025215954.73549810@jic23-hlaptop/
[2] https://lore.kernel.org/linux-iio/[email protected]/
[3] https://github.com/bvanassche/linux/tree/thread-safety

Cc Marco Elver <[email protected]>
Cc Bart Van Assche <[email protected]>

Rupesh Majhi (9):
iio: adc: qcom-spmi-adc5-gen3: fix lock annotations on mutex helpers
iio: core: annotate the conditional mode claims
iio: core: mark the mode lock helpers __context_unsafe
iio: accel: kionix-kx022a: annotate the lock helpers
iio: adc: meson_saradc: annotate the lock helpers
iio: buffer-dma: annotate the queue lock helpers
iio: light: opt3001: mark the interrupt handler __context_unsafe
iio: light: veml6031x00: annotate the event enable helpers
iio: enable context analysis for all drivers

 drivers/iio/Makefile                         | 2 ++
 drivers/iio/accel/Makefile                   | 2 ++
 drivers/iio/accel/kionix-kx022a.c            | 2 ++
 drivers/iio/adc/Makefile                     | 2 ++
 drivers/iio/adc/meson_saradc.c               | 2 ++
 drivers/iio/adc/qcom-spmi-adc5-gen3.c        | 4 ++--
 drivers/iio/addac/Makefile                   | 2 ++
 drivers/iio/afe/Makefile                     | 2 ++
 drivers/iio/amplifiers/Makefile              | 2 ++
 drivers/iio/buffer/Makefile                  | 2 ++
 drivers/iio/buffer/industrialio-buffer-dma.c | 2 ++
 drivers/iio/cdc/Makefile                     | 2 ++
 drivers/iio/chemical/Makefile                | 2 ++
 drivers/iio/common/cros_ec_sensors/Makefile  | 2 ++
 drivers/iio/common/hid-sensors/Makefile      | 2 ++
 drivers/iio/common/inv_sensors/Makefile      | 2 ++
 drivers/iio/common/ms_sensors/Makefile       | 2 ++
 drivers/iio/common/scmi_sensors/Makefile     | 3 +++
 drivers/iio/common/ssp_sensors/Makefile      | 2 ++
 drivers/iio/common/st_sensors/Makefile       | 2 ++
 drivers/iio/dac/Makefile                     | 2 ++
 drivers/iio/dummy/Makefile                   | 2 ++
 drivers/iio/filter/Makefile                  | 2 ++
 drivers/iio/flow/Makefile                    | 2 ++
 drivers/iio/frequency/Makefile               | 2 ++
 drivers/iio/gyro/Makefile                    | 2 ++
 drivers/iio/health/Makefile                  | 2 ++
 drivers/iio/humidity/Makefile                | 2 ++
 drivers/iio/imu/Makefile                     | 2 ++
 drivers/iio/imu/bmi160/Makefile              | 3 +++
 drivers/iio/imu/bmi270/Makefile              | 3 +++
 drivers/iio/imu/bmi323/Makefile              | 3 +++
 drivers/iio/imu/bno055/Makefile              | 2 ++
 drivers/iio/imu/inv_icm42600/Makefile        | 2 ++
 drivers/iio/imu/inv_icm42607/Makefile        | 2 ++
 drivers/iio/imu/inv_icm45600/Makefile        | 2 ++
 drivers/iio/imu/inv_mpu6050/Makefile         | 2 ++
 drivers/iio/imu/smi330/Makefile              | 3 +++
 drivers/iio/imu/st_lsm6dsx/Makefile          | 3 +++
 drivers/iio/imu/st_lsm9ds0/Makefile          | 3 +++
 drivers/iio/industrialio-core.c              | 2 ++
 drivers/iio/light/Makefile                   | 2 ++
 drivers/iio/light/opt3001.c                  | 1 +
 drivers/iio/light/veml6031x00.c              | 2 ++
 drivers/iio/magnetometer/Makefile            | 2 ++
 drivers/iio/multiplexer/Makefile             | 2 ++
 drivers/iio/orientation/Makefile             | 2 ++
 drivers/iio/position/Makefile                | 2 ++
 drivers/iio/potentiometer/Makefile           | 2 ++
 drivers/iio/potentiostat/Makefile            | 2 ++
 drivers/iio/pressure/Makefile                | 2 +-
 drivers/iio/proximity/Makefile               | 2 ++
 drivers/iio/resolver/Makefile                | 2 ++
 drivers/iio/sensorhubs/osf/Makefile          | 2 ++
 drivers/iio/temperature/Makefile             | 2 ++
 drivers/iio/test/Makefile                    | 2 ++
 drivers/iio/trigger/Makefile                 | 2 ++
 include/linux/iio/iio.h                      | 9 ++-------
 58 files changed, 121 insertions(+), 10 deletions(-)

base-commit: 7d80b4b383bc53b48abd3a30ca4a91cdab568bfa

Signature · 1 line
2.43.0