Add support for storage element depopulation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v12 Latest13 patches 0 repliesNew
- v1113 patches 4 repliesSuperseded
- v1013 patches 2 repliesSuperseded
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 | 13 patches | 4 replies | Superseded | |
| v8 | 12 patches | 14 replies | Superseded | |
| v7 | 10 patches | 3 replies | Superseded | |
| v6 | 10 patches | 19 replies | Superseded | |
| v5 | 9 patches | 12 replies | Superseded | |
| v4 | 9 patches | 3 replies | Superseded | |
| v3 | 7 patches | 8 replies | Superseded | |
| v2 | 7 patches | 1 reply | Superseded | |
| v1 | 7 patches | 9 replies | Superseded |
Changes in v12 from the cover letter
- Addressed two silly mistakes pointed out by Sashiko in patch 8 (missing EIO error return) and patch 12 (dead code left over from previous version).
Patches in v12 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | block: introduce disk_zone_is_offline()block/ include/ | +27 | 0 replies | |
| 2/13 | block: refactor blk_revalidate_disk_zones()block/ | +34 | 0 replies | |
| 3/13 | block: allow dropping all zone write plugs on revalidationblock/ | +5 | 0 replies | |
| 4/13 | block: introduce storage element managementblock/ block/ block/ +2 more | +334 | 0 replies | |
| 5/13 | block: add storage element management ioctlsblock/ block/ block/ +2 more | +218 | 0 replies | |
| 6/13 | zloop: fix ordered zone append handlingdrivers/ | +45 | 0 replies | |
| 7/13 | zloop: fix zone reporting consistencydrivers/ | +1 | 0 replies | |
| 8/13 | zloop: add storage element emulationDocumentation/ drivers/ | +696 | 0 replies | |
| 9/13 | zloop: add degrade_element control commandDocumentation/ drivers/ | +121 | 0 replies | |
| 10/13 | scsi: scsi_proto: refine the definition of storage element healthinclude/ | +4 | 0 replies | |
| 11/13 | scsi: sd_zbc: always revalidate zones for disks supporting head depopulationdrivers/ drivers/ | +47 | 0 replies | |
| 12/13 | scsi: sd_zbc: define storage element management operationsdrivers/ drivers/ drivers/ | +484 | 0 replies | |
| 13/13 | scsi: sd: fail read commands to offline zones earlydrivers/ | +19 | 0 replies |
Reviews trailers per patch
11 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Martin K. Petersen | Hannes Reinecke |
|---|---|---|---|
| 1/13 | R-b | R-b | R-b |
| 2/13 | R-b | R-b | R-b |
| 3/13 | R-b | R-b | |
| 4/13 | R-b | R-b | |
| 5/13 | R-b | R-b | |
| 6/13 | R-b | ||
| 7/13 | R-b | R-b | |
| 8/13 | |||
| 9/13 | R-b | R-b | R-b |
| 10/13 | R-b | R-b | |
| 11/13 | R-b | R-b | |
| 12/13 | |||
| 13/13 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v12 00/13] Add support for storage element depopulation
Jens,
These patches define a new set of block device operations for generically using from the block layer the storage element depopulation feature of zoned block devices. Support for this feature is added to the SCSI disk driver and an emulation of this feature added to the zloop driver.
The management operations can be accessed using block layer API, which is intended for file systems (e.g. zonefs and XFS), as well as using ioctls for users using zoned disks directly from user space.
Changes from v11:
- Addressed two silly mistakes pointed out by Sashiko in patch 8 (missing EIO error return) and patch 12 (dead code left over from previous version).
Changes from v10:
- Addressed sashiko comment on patch 8 and 12.
- Added review tags
Changes from v9:
- Addressed Sashiko comments on patch 6. This change redesigns the ordered zone append handling to simplify the code and avoid locking difficulties.
- Addressed Sashiko comments on patch 8.
Changes from v8:
- Addressed Sashiko comment on patch 7 by adding patch 6. Patch 7 is unmodified.
- Addressed Sashiko comments on patch 8 and patch 12
- Added review tags to unmodified pacthes
Changes from v7:
A significant amount of changes in this version to address most of the Sashiko review comments and to simplify the code. In more details, the changes are:
- Added patches 3, 6, and 9.
- Dropped former patch 5 as the use of irq-disabling spinlocks in zloop is not necessary.
- Reworked patch 4 by migrating the idepop operation wait loops to the device drivers. This simplifies the implementation in zloop without making the sd driver implementation more difficult. Also fixed problems with errors during restoration and zone write plugs state.
- Reworked patch 7 and 11 to be consistent with the changes in patch 4.
Changes from v6:
- Addressed the nit pointed out by Christoph in patch 4
- Added review tags
Changes from v5:
- Rebased on latest block/for-next
- Addressed Christoph's comments on patch 3
- Added patch 5 to address a potential deadlock in zloop (signaled by sashiko)
- Reworked the restoration of storage elements in patch 6 to avoid an inconsistent state of storage elements in case of error. Also added protection against disk removal during storage element removal and restoration execution.
- Added review tags
Changes from v4:
- Rebased on latest block/for-next
- Added review tags to patch 1 and 2
- Reworked patch 3, 4 and 5 to address Christoph's and sashiko comments
Changes from v3:
- Reworked patch 1 to only provide the disk_zone_is_offline() helper function. Failing of read operations to offline zones is handled directly by the zloop driver and the new patch 7 is added to handle failing early read operations to offline zones of ZBC SCSI disks.
- Added patch 2
- Addressed further valid comments from Sashiko
The biggest changes are in patch 2 to save the number of storage elements of a disk in struct gendisk and to serialize the execution of the storage element management operations using the zone revalidation mutex.
- Rebased on latest block/for-next
Changes from v2:
- Addressed further valid comments from Sashiko
- Rebased on latest block/for-next
Changes from v1:
- Addressed the many valid comments that Sashiko had
- Rebased on latest block/for-next
Damien Le Moal (13):
block: introduce disk_zone_is_offline()
block: refactor blk_revalidate_disk_zones()
block: allow dropping all zone write plugs on revalidation
block: introduce storage element management
block: add storage element management ioctls
zloop: fix ordered zone append handling
zloop: fix zone reporting consistency
zloop: add storage element emulation
zloop: add degrade_element control command
scsi: scsi_proto: refine the definition of storage element health
scsi: sd_zbc: always revalidate zones for disks supporting head depopulation
scsi: sd_zbc: define storage element management operations
scsi: sd: fail read commands to offline zones early
.../admin-guide/blockdev/zoned_loop.rst | 36 +- block/blk-zoned.c | 450 ++++++++- block/blk.h | 14 + block/genhd.c | 4 + block/ioctl.c | 4 + drivers/block/zloop.c | 919 ++++++++++++++++-- drivers/scsi/sd.c | 23 +- drivers/scsi/sd.h | 5 + drivers/scsi/sd_zbc.c | 524 +++++++++- include/linux/blkdev.h | 64 ++ include/scsi/scsi_proto.h | 6 +- include/uapi/linux/blkzoned.h | 106 ++ include/uapi/linux/fs.h | 1 + 13 files changed, 2027 insertions(+), 129 deletions(-)
Signature · 1 line
2.56.1