emulator: Fix extended advertising report types
Status from this message: This series was applied to bluetooth/bluez.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | emulator: Remove unused le_ext_adv_typeemulator/ | +0 | 1 reply | |
| 2/3 | emulator: Fix extended scan response Event_Typeemulator/ | +1 | 0 replies | |
| 3/3 | emulator: Fix report type after a scan responseemulator/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH BlueZ 0/3] emulator: Fix extended advertising report types
btdev sends the wrong Event_Type in two of the LE Extended Advertising Reports it generates for an advertising set:
- the scan response to non-legacy scannable advertising is reported with Event_Type 0x0000 instead of 0x000a
- with more than one active scanner, every scanner after the first gets the advertisement reported as a scan response
The first patch removes le_ext_adv_type, which sits next to this code and has been unused since advertising sets got their own struct.
I reproduced both with a small test driving an advertiser and two scanners in-process. On master it shows:
scannable set: scan response 0x0000, expected 0x000a two scanners: scanner 1 adv 0x001b, expected 0x0013
I can send it as a unit test if that would be useful.
mgmt-tester, iso-tester and smp-tester give the same results with and without the series, apart from LL Privacy tests that fail intermittently on both.
Kevin Dewald (3):
emulator: Remove unused le_ext_adv_type
emulator: Fix extended scan response Event_Type
emulator: Fix report type after a scan response
emulator/btdev.c | 37 ++++++------------------------------- 1 file changed, 6 insertions(+), 31 deletions(-)
Signature · 1 line
2.54.0 (Apple Git-157)