Skip to content

emulator: Fix extended advertising report types

Kevin Dewald linux-bluetooth 1 version Applied

Status from this message: This series was applied to bluetooth/bluez.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3emulator: Remove unused le_ext_adv_typeemulator/btdev.c+0 -271 reply
2/3emulator: Fix extended scan response Event_Typeemulator/btdev.c+1 -10 replies
3/3emulator: Fix report type after a scan responseemulator/btdev.c+6 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH BlueZ 0/3] emulator: Fix extended advertising report types

btdev sends the wrong Event_Type in two of the LE Extended Advertising Reports it generates for an advertising set:

- the scan response to non-legacy scannable advertising is reported with Event_Type 0x0000 instead of 0x000a
- with more than one active scanner, every scanner after the first gets the advertisement reported as a scan response

The first patch removes le_ext_adv_type, which sits next to this code and has been unused since advertising sets got their own struct.

I reproduced both with a small test driving an advertiser and two scanners in-process. On master it shows:

scannable set: scan response 0x0000, expected 0x000a two scanners: scanner 1 adv 0x001b, expected 0x0013

I can send it as a unit test if that would be useful.

mgmt-tester, iso-tester and smp-tester give the same results with and without the series, apart from LL Privacy tests that fail intermittently on both.

Kevin Dewald (3):
emulator: Remove unused le_ext_adv_type
emulator: Fix extended scan response Event_Type
emulator: Fix report type after a scan response

 emulator/btdev.c | 37 ++++++-------------------------------
 1 file changed, 6 insertions(+), 31 deletions(-)
Signature · 1 line
2.54.0 (Apple Git-157)