Skip to content

ASoC: mediatek: Handle constraint return value in FE startup

[email protected] linux-arm-kernel linux-mediatek linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 3 repliesIn review

Changes in v2 from the cover letter

- Rename the patch subject.
- Simplify the code change as suggested by Cezary.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: mediatek: common: Handle constraint return value in FE startupsound/soc/mediatek/common/mtk-afe-fe-dai.c+5 -30 replies
2/4ASoC: mediatek: mt8188: Handle constraint return value in FE startupsound/soc/mediatek/mt8188/mt8188-afe-pcm.c+3 -00 replies
3/4ASoC: mediatek: mt8189: Handle constraint return value in FE startupsound/soc/mediatek/mt8189/mt8189-afe-pcm.c+5 -30 replies
4/4ASoC: mediatek: mt8365: Handle constraint return value in FE startupsound/soc/mediatek/mt8365/mt8365-afe-pcm.c+5 -20 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCezary Rojewski
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] ASoC: mediatek: Handle constraint return value in FE startup

From: bui duc phuc <[email protected]>

Hi all,

Some FE startup callbacks may return a positive value from constraint helpers, but ASoC expects 0 on success. This can cause .shutdown() to be skipped during rollback.

Return 0 explicitly on success.

Compile-tested only.

Changes in v2:
- Rename the patch subject.
- Simplify the code change as suggested by Cezary.

Best regards,
Phuc

bui duc phuc (4):
ASoC: mediatek: common: Handle constraint return value in FE startup
ASoC: mediatek: mt8188: Handle constraint return value in FE startup
ASoC: mediatek: mt8189: Handle constraint return value in FE startup
ASoC: mediatek: mt8365: Handle constraint return value in FE startup

 sound/soc/mediatek/common/mtk-afe-fe-dai.c | 8 +++++---
 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 3 +++
 sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 8 +++++---
 sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 7 +++++--
 4 files changed, 18 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0