Skip to content

ASoC: Fix constraint return value handling

[email protected] asahi imx linux-renesas-soc linux-rockchip linux-sound linuxppc-dev lkml sashiko-reviews 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 8 repliesIn review
  2. v124 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Add Reviewed-by tags from Vijendar Mukunda and Chancel Liu.
- Remove redundant integer constraints already applied by snd_dmaengine_pcm_open().

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25ASoC: amd: acp: Fix .close() being skipped on rollbacksound/soc/amd/acp/acp-platform.c+6 -11 reply
2/25ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollbacksound/soc/amd/ps/ps-pdm-dma.c+7 -10 replies
3/25ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollbacksound/soc/amd/ps/ps-sdw-dma.c+7 -10 replies
4/25ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollbacksound/soc/amd/raven/acp3x-pcm-dma.c+7 -10 replies
5/25ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollbacksound/soc/amd/renoir/acp3x-pdm-dma.c+7 -10 replies
6/25ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollbacksound/soc/amd/vangogh/acp5x-pcm-dma.c+7 -10 replies
7/25ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollbacksound/soc/amd/yc/acp6x-pdm-dma.c+7 -10 replies
8/25ASoC: apple: mca: Ensure the DAI is marked as started on successsound/soc/apple/mca.c+13 -30 replies
9/25ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on rollbacksound/soc/atmel/atmel-pcm-pdc.c+7 -00 replies
10/25ASoC: codecs: cs42l42: Ensure the DAI is marked as started on successsound/soc/codecs/cs42l42.c+13 -30 replies
11/25ASoC: codecs: nau8325: Ensure the DAI is marked as started on successsound/soc/codecs/nau8325.c+13 -30 replies
12/25ASoC: codecs: nau8540: Ensure the DAI is marked as started on successsound/soc/codecs/nau8540.c+13 -30 replies
13/25ASoC: codecs: nau8821: Ensure the DAI is marked as started on successsound/soc/codecs/nau8821.c+13 -30 replies
14/25ASoC: codecs: nau8824: Ensure the DAI is marked as started on successsound/soc/codecs/nau8824.c+13 -30 replies
15/25ASoC: codecs: nau8825: Ensure the DAI is marked as started on successsound/soc/codecs/nau8825.c+13 -30 replies
16/25ASoC: codecs: wm8580: Ensure the DAI is marked as started on successsound/soc/codecs/wm8580.c+13 -20 replies
17/25ASoC: codecs: wm8782: Ensure the DAI is marked as started on successsound/soc/codecs/wm8782.c+11 -10 replies
18/25ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on rollbacksound/soc/fsl/imx-pcm-rpmsg.c+7 -10 replies
19/25ASoC: intel: atom: Fix .shutdown() being skipped on rollbacksound/soc/intel/atom/sst-mfld-platform-pcm.c+6 -11 reply
20/25ASoC: renesas: fsi: Ensure the component is marked as opened on successsound/soc/renesas/fsi.c+9 -21 reply
21/25ASoC: renesas: msiof: Remove redundant period constraintsound/soc/renesas/rcar/msiof.c+6 -101 reply
22/25ASoC: renesas: rz-ssi: Ensure the component is marked as opened on successsound/soc/renesas/rz-ssi.c+12 -10 replies
23/25ASoC: renesas: rz-ssi: Remove redundant component open callbacksound/soc/renesas/rz-ssi.c+0 -80 replies
24/25ASoC: rockchip: rk3399_gru_sound: Mark the link as started on successsound/soc/rockchip/rk3399_gru_sound.c+12 -20 replies
25/25ASoC: rockchip: rockchip_max98090: Mark the link as started on successsound/soc/rockchip/rockchip_max98090.c+13 -22 replies

Reviews trailers per patch

11 of 25 patches have a Reviewed-by or Acked-by.

PatchVijendar MukundaChancel LiuKuninori MorimotoCezary Rojewski
1/25R-b
2/25R-b
3/25R-b
4/25R-b
5/25R-b
6/25R-b
7/25R-b
8/25
9/25
10/25
11/25
12/25
13/25
14/25
15/25
16/25
17/25
18/25R-b
19/25A-b
20/25A-b
21/25A-b
22/25
23/25
24/25
25/25

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/25] ASoC: Fix constraint return value handling

From: bui duc phuc <[email protected]>

Hi all,

snd_pcm_hw_constraint_minmax() and snd_pcm_hw_constraint_integer() may return positive values on success. However, ASoC only marks the DAI, link, or component as started or opened when the corresponding callback returns 0.

This series fixes affected ASoC drivers to return 0 on success and properly handle rollback paths.

Found by manual code inspection.

Compile-tested only.

Link v1:
https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Add Reviewed-by tags from Vijendar Mukunda and Chancel Liu.
- Remove redundant integer constraints already applied by snd_dmaengine_pcm_open().

Best regards,
Phuc

bui duc phuc (25):
ASoC: amd: acp: Fix .close() being skipped on rollback
ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback
ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollback
ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback
ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback
ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback
ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback
ASoC: apple: mca: Ensure the DAI is marked as started on success
ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on
rollback
ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success
ASoC: codecs: nau8325: Ensure the DAI is marked as started on success
ASoC: codecs: nau8540: Ensure the DAI is marked as started on success
ASoC: codecs: nau8821: Ensure the DAI is marked as started on success
ASoC: codecs: nau8824: Ensure the DAI is marked as started on success
ASoC: codecs: nau8825: Ensure the DAI is marked as started on success
ASoC: codecs: wm8580: Ensure the DAI is marked as started on success
ASoC: codecs: wm8782: Ensure the DAI is marked as started on success
ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on
rollback
ASoC: intel: atom: Fix .shutdown() being skipped on rollback
ASoC: renesas: fsi: Ensure the component is marked as opened on
success
ASoC: renesas: msiof: Remove redundant period constraint
ASoC: renesas: rz-ssi: Ensure the component is marked as opened on
success
ASoC: renesas: rz-ssi: Remove redundant component open callback
ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success
ASoC: rockchip: rockchip_max98090: Mark the link as started on success

 sound/soc/amd/acp/acp-platform.c             |  7 ++++++-
 sound/soc/amd/ps/ps-pdm-dma.c                |  8 +++++++-
 sound/soc/amd/ps/ps-sdw-dma.c                |  8 +++++++-
 sound/soc/amd/raven/acp3x-pcm-dma.c          |  8 +++++++-
 sound/soc/amd/renoir/acp3x-pdm-dma.c         |  8 +++++++-
 sound/soc/amd/vangogh/acp5x-pcm-dma.c        |  8 +++++++-
 sound/soc/amd/yc/acp6x-pdm-dma.c             |  8 +++++++-
 sound/soc/apple/mca.c                        | 16 +++++++++++++---
 sound/soc/atmel/atmel-pcm-pdc.c              |  7 +++++++
 sound/soc/codecs/cs42l42.c                   | 16 +++++++++++++---
 sound/soc/codecs/nau8325.c                   | 16 +++++++++++++---
 sound/soc/codecs/nau8540.c                   | 16 +++++++++++++---
 sound/soc/codecs/nau8821.c                   | 16 +++++++++++++---
 sound/soc/codecs/nau8824.c                   | 16 +++++++++++++---
 sound/soc/codecs/nau8825.c                   | 16 +++++++++++++---
 sound/soc/codecs/wm8580.c                    | 15 +++++++++++++--
 sound/soc/codecs/wm8782.c                    | 12 +++++++++++-
 sound/soc/fsl/imx-pcm-rpmsg.c                |  8 +++++++-
 sound/soc/intel/atom/sst-mfld-platform-pcm.c |  7 ++++++-
 sound/soc/renesas/fsi.c                      | 11 +++++++++--
 sound/soc/renesas/rcar/msiof.c               | 16 ++++++----------
 sound/soc/renesas/rz-ssi.c                   | 19 +++++++++++--------
 sound/soc/rockchip/rk3399_gru_sound.c        | 14 ++++++++++++--
 sound/soc/rockchip/rockchip_max98090.c       | 15 +++++++++++++--
 24 files changed, 234 insertions(+), 57 deletions(-)
Signature · 1 line
2.43.0