Skip to content

platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeout

[email protected] linux-acpi lkml oe-kbuild-all platform-driver-x86 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 0 repliesSuperseded
  3. v21 patch 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v4 from the cover letter

- Revert __free(pci_dev_put) to manual pci_dev_put() calls to fix build error when CONFIG_PCI is disabled (kernel test robot)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: dell-uart-backlight: extract dell_uart_bl_init() from probedrivers/platform/x86/dell/dell-uart-backlight.c+32 -270 replies
2/2platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeoutdrivers/platform/x86/dell/dell-uart-backlight.c+108 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeout

From: Chitransh Mandhaniya <[email protected]>

Some Dell OptiPlex AIO 7410 (35W) ship with DELL0501 in ACPI but no physical UART scalar board, leaving the machine with zero backlight control after the UART probe times out.

Patch 1 is a preparatory refactor that extracts the UART initialization sequence into dell_uart_bl_init() so the probe function can inspect its return value.

Patch 2 adds a PCH PWM fallback path: when dell_uart_bl_init() returns -ETIMEDOUT, the driver reads the Intel PCH BLC_PWM registers and registers a BACKLIGHT_PLATFORM device.

v3 -> v4:
- Revert __free(pci_dev_put) to manual pci_dev_put() calls to fix build error when CONFIG_PCI is disabled (kernel test robot)

v2 -> v3:
- Split into two patches: preparatory refactor + fallback (Ilpo)

v1 -> v2:
- Use SZ_16 instead of 0x10, add linux/sizes.h (Ilpo)
- Name BIT(31) as PCH_BLC_PWM_ENABLE (Ilpo)
- Fix double-space in block comment (Ilpo)
- Reduce devm_backlight_device_register() to fewer lines (Ilpo)
- Extract dell_uart_bl_init() for the normal UART backlight path (Ilpo)

Chitransh Mandhaniya (2):
platform/x86: dell-uart-backlight: extract dell_uart_bl_init() from
probe
platform/x86: dell-uart-backlight: fall back to PCH PWM on UART
timeout

 .../platform/x86/dell/dell-uart-backlight.c   | 158 +++++++++++++++---
 1 file changed, 135 insertions(+), 23 deletions(-)
Signature · 1 line
2.43.0