Skip to content

KVM: nVMX: fix nested APICv emulation for windows guests

Maxim Levitsky kvm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: nVMX: don't check PIR.ON when processing nested posted interruptsarch/x86/kvm/vmx/nested.c+11 -40 replies
2/2KVM: nVMX: avoid losing the posted notification interrupt when exiting L2arch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/vmx.c+12 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] KVM: nVMX: fix nested APICv emulation for windows guests

Fix two problems that were recently discovered that cause nested APICv to malfunction on windows with hyperv enabled.

The first problem is that unlike KVM, windows doesn't set PIR.ON when sending posted interrupts. X86 spec actually allows this.

The second problem is that unlilke KVM, which mostly ignores them, windows depends on accurate delivery of the posted notification interrupts, and currently it is possible for a posted notification to get lost it it arrives at the same time as the nested VM exit.

V2: to avoid spurious notification in L1, process the posted notification in L2, just before VM exit.

PS: I am not 100% sure if I got the barriers right, plus I am not sure about what to do if vmx_complete_nested_posted_interrupt can't write to the nested PIR, in this it calls kvm_handle_memory_failure, and I don't know 100% its interactions with nested VM exit.

Best regards,
Maxim Levitsky

Maxim Levitsky (2):
KVM: nVMX: don't check PIR.ON when processing nested posted interrupts
KVM: nVMX: avoid losing the posted notification interrupt when exiting

    L2
 arch/x86/kvm/vmx/nested.c | 22 ++++++++++++++++++----
 arch/x86/kvm/vmx/vmx.c    |  5 +++++
 2 files changed, 23 insertions(+), 4 deletions(-)
Signature · 1 line
2.54.0