Skip to content

drm/xe: Handle GuC semaphore instruction field check error

Jesus Narvaez intel-xe 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v42 patches 1 replySuperseded
  3. v31 patch 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch1 replySuperseded
v11 patch3 repliesSuperseded

Changes in v5 from the cover letter

- Patch 1: Updated to Tilak's v2, which now only compares has_sem64 when both GTs are present (Daniele). Added Daniele's Reviewed-by.
- Patch 2: No changes from v4.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/xe: Add has_sem64 bit to graphics/media IP descriptorsdrivers/gpu/drm/xe/xe_gt_types.h drivers/gpu/drm/xe/xe_pci.c drivers/gpu/drm/xe/xe_pci_types.h+29 -20 replies
2/2drm/xe/guc: Handle GuC semaphore instruction field check errordrivers/gpu/drm/xe/abi/guc_actions_abi.h drivers/gpu/drm/xe/abi/guc_klvs_abi.h drivers/gpu/drm/xe/xe_guc.c +4 more+78 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDaniele Ceraolo Spurio
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] drm/xe: Handle GuC semaphore instruction field check error

This series enables the driver to opt in to have the GuC check the SW Token Info field of 64 bit semaphore instructions and then handle the G2H received from the GuC when an unsupported value is detected.

Originally, I only had the patch to opt in to the GuC feature, but after becoming aware of the series to add and use the has_sem64 flag, I added the has_sem64 flag definition to this series and updated the opt-in patch to use the new flag, with Tilak's permission.

Patches:
1. drm/xe: Add has_sem64 bit to graphics/media IP descriptors Tilak's patch, carried over to this series unmodified (his v2)
2. drm/xe/guc: Handle GuC semaphore instruction field check error Opts in to the GuC check when has_sem64 is set, and handles the G2H

Changes in v5:
- Patch 1: Updated to Tilak's v2, which now only compares has_sem64 when both GTs are present (Daniele). Added Daniele's Reviewed-by.
- Patch 2: No changes from v4.

Changes in v4:
- Patch 1: Added Tilak's patch to series, carried over unmodified.
- Patch 2: Updated to use the has_sem64 flag in the opt-in condition and updated comments accordingly. Daniele's Reviewed-by for v3 is kept with his permission.

v3 of the GuC patch: https://lore.kernel.org/all/[email protected]/
Tilak's patch: https://lore.kernel.org/all/[email protected]/

Jesus Narvaez (1):
drm/xe/guc: Handle GuC semaphore instruction field check error

Tangudu Tilak Tirumalesh (1):
drm/xe: Add has_sem64 bit to graphics/media IP descriptors

 drivers/gpu/drm/xe/abi/guc_actions_abi.h |  1 +
 drivers/gpu/drm/xe/abi/guc_klvs_abi.h    | 10 ++++++
 drivers/gpu/drm/xe/xe_gt_types.h         |  2 ++
 drivers/gpu/drm/xe/xe_guc.c              | 10 ++++++
 drivers/gpu/drm/xe/xe_guc_ct.c           |  4 +++
 drivers/gpu/drm/xe/xe_guc_submit.c       | 46 ++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_guc_submit.h       |  2 ++
 drivers/gpu/drm/xe/xe_pci.c              | 27 ++++++++++++--
 drivers/gpu/drm/xe/xe_pci_types.h        |  2 ++
 drivers/gpu/drm/xe/xe_trace.h            |  5 +++
 10 files changed, 107 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0