Skip to content

serial: pmac_zilog: two receive fixes

Tim Douglas linux-serial linuxppc-dev lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2serial: pmac_zilog: push received data to the port that received itdrivers/tty/serial/pmac_zilog.c+2 -20 replies
2/2serial: pmac_zilog: report received breaksdrivers/tty/serial/pmac_zilog.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] serial: pmac_zilog: two receive fixes

These two patches fix receive problems in pmac_zilog that I ran into while bringing up the serial ports on a Performa 6200CD, a NuBus Power Macintosh. The first stops data received on one port from being left in its flip buffer while the other port is open. The second makes received breaks visible; until now they arrived as plain NUL characters.

I tested both on the 6200, running 7.2.8 with an out-of-tree platform port and a loopback plug on the printer port. Without the series, only 3 of 8 bytes written to ttyPZ1 came back while ttyPZ0 was open, and a break sent with tcsendbreak() arrived as a NUL with no break counted. With the series, all 8 bytes came back, the break was counted, and with PARMRK set it read as FF 00 00.

The series also builds on v7.3-rc7 with pmac32_defconfig and W=1 without warnings. I have not tested 68k Macs or macio Power Macs.

I found these bugs and wrote the patches with the help of Claude Opus 5.5. I have reviewed both patches and run the tests on the 6200 myself.

Tim Douglas (2):
serial: pmac_zilog: push received data to the port that received it
serial: pmac_zilog: report received breaks

 drivers/tty/serial/pmac_zilog.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907

Signature · 1 line
2.54.0 (Apple Git-157)