Skip to content

rtc: ds1685: power-off fixes

Imre Kaloz linux-rtc lkml 2 versions Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- New patch 2: use mdelay() instead of msleep() before the PAB write.
- Patch 3 (v1 patch 2): use mdelay() instead of msleep() in the repeat loop.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is setdrivers/rtc/rtc-ds1685.c+12 -60 replies
2/3rtc: ds1685: do not sleep in the power-off handlerdrivers/rtc/rtc-ds1685.c+1 -10 replies
3/3rtc: ds1685: keep setting PAB until power is removeddrivers/rtc/rtc-ds1685.c+13 -70 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJoshua Kinard
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] rtc: ds1685: power-off fixes

Three fixes for ds1685_rtc_poweroff(), on SGI O2 and Octane machines.

Patch 1 arms the wake-up alarm only if an alarm is set, so that stale alarm registers no longer power the machine back on.

Patch 2 replaces the sleep before the PAB write with a busy wait, as power-off handlers must not sleep.

Patch 3 repeats the PAB write, clearing the kickstart and wake-up flags with it, until power is removed.

Patch 1 was tested on an O2, and the whole series on an Octane.

Changes in v2:
- New patch 2: use mdelay() instead of msleep() before the PAB write.
- Patch 3 (v1 patch 2): use mdelay() instead of msleep() in the repeat loop.

v1: https://lore.kernel.org/all/[email protected]/

Imre Kaloz (3):
rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is
set
rtc: ds1685: do not sleep in the power-off handler
rtc: ds1685: keep setting PAB until power is removed

 drivers/rtc/rtc-ds1685.c | 40 ++++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907

Signature · 1 line
2.47.3