Add __must_init and require explicit kobj_type::release
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 0 repliesNew
- v39 patches 12 repliesSuperseded
- v29 patches 11 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 11 patches | 12 replies | Superseded |
Changes in v4 from the cover letter
- Rebased on v7.4-rc3.
- Patch 2 (powerpc/secvar): Add Reviewed-by from Srish Srinivasan and Acked-by from Madhavan Srinivasan.
- Patch 3 (sh: sq): Add Acked-by from John Paul Adrian Glaubitz.
- Patch 5 (dlm): Clarify subject ("Wait for kobject release before freeing dlm_ls") and update Fixes tag to commit 8a4cf500f1dd ("dlm:
drop kobject release callback handling") (reported by Sashiko).
- Patch 6 (xen/sys-hypervisor): Add Reviewed-by from Juergen Gross.
- Patch 7 (ubifs): Update Fixes tag to commit 2e3cbf425804 ("ubifs:
Export filesystem error counters") (reported by Sashiko).
- Patch 9 (kobject): Drop the "Pre-existing:" comment prefix and explicitly distinguish built-in sites whose storage outlives kobject cleanup (arm64 cpuinfo, ACPI hotplug profiles, s390 sclp_mem) from drivers and tristate modules with broken kobject lifetime management, documenting each lifetime hazard with a FIXME comment for follow-up fixes (requested by Danilo Krummrich).
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | Compiler Attributes: Add __must_init macroDocumentation/ include/ scripts/ +1 more | +15 | 0 replies | |
| 2/9 | powerpc/secvar: Add missing kobject release callback to secvar_ktypearch/ | +6 | 0 replies | |
| 3/9 | sh: sq: Add missing kobject release callback to ktype_percpu_entryarch/ | +6 | 0 replies | |
| 4/9 | cpufreq: governor: Initialize kobj_type release callback staticallydrivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 5/9 | dlm: Wait for kobject release before freeing dlm_lsfs/ fs/ | +21 | 0 replies | |
| 6/9 | xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_typedrivers/ | +6 | 0 replies | |
| 7/9 | ubifs: sysfs: Use kset_create_and_add() for ubifs_ksetfs/ | +7 | 0 replies | |
| 8/9 | drm/amdkfd: Free queue in procfs_queue_type kobject release callbackdrivers/ drivers/ | +13 | 0 replies | |
| 9/9 | kobject: Require explicit initialization of struct kobj_type::releasearch/ drivers/ drivers/ +15 more | +166 | 0 replies |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Miguel Ojeda | Nick Desaulniers | Nathan Chancellor | Greg Kroah-Hartman | Kees Cook | Srish Srinivasan | Madhavan Srinivasan | John Paul Adrian Glaubitz | Zhongqiu Han | Rafael J. Wysocki (Intel) | Viresh Kumar | Alexander Aring | Juergen Gross | Zhihao Cheng | Felix Kuehling |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/9 | A-b | R-b | R-b | A-b | R-b | ||||||||||
| 2/9 | R-b | A-b | |||||||||||||
| 3/9 | A-b | ||||||||||||||
| 4/9 | R-b | A-b | A-b | ||||||||||||
| 5/9 | A-b | ||||||||||||||
| 6/9 | R-b | ||||||||||||||
| 7/9 | T-b R-b | ||||||||||||||
| 8/9 | R-b | ||||||||||||||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 15 reviewers.
Cover letter [PATCH v4 0/9] Add __must_init and require explicit kobj_type::release
Clang supports the 'require_explicit_initialization' attribute on struct fields to enforce that the field is explicitly initialized when an aggregate object is constructed, emitting -Wuninitialized-explicit-init (enabled by default) if the field is omitted.
Following discussion at the Linux Plumbers Conference [1], patch 1 adds the attribute to include/linux/compiler_attributes.h as __must_init. In v1 it was called __require_explicit_initialization. Kees picked up that patch with a first seq_file user [2], and in that thread Greg suggested the shorter __must_init spelling, which Kees and Miguel agreed to. As the attribute did not land in the v7.4 merge window, Kees asked that this series carry the renamed attribute.
As Documentation/core-api/kobject.rst notes:
"One important point cannot be overstated: every kobject must have a release() method, and the kobject must persist (in a consistent state) until that method is called. If these constraints are not met, the code is flawed."
Annotating struct kobj_type::release caught struct kobj_type definitions across the tree that omitted .release:
- Patches 2-8 fix struct kobj_type definitions where dynamically allocated kobjects, ksets, or enclosing structures were either leaked on kobject_put(), freed prematurely before kobject release, or missing proper static initializers.
- Patch 9 annotates struct kobj_type::release with __must_init and explicitly sets .release = NULL on the remaining legacy struct kobj_type definitions, distinguishing built-in sites whose backing storage remains valid for the lifetime of the kernel (despite violating the kobject API contract) from sites with broken kobject lifetime management (marked with FIXME comments for follow-up fixes).
Danilo Krummrich offered to route the series as a whole through the driver-core tree [3], and all subsystem maintainer Acked-by/Reviewed-by tags for patches 1-8 have now been collected. Follow-up patches are planned for the broken-lifetime sites documented in patch 9.
Note on tool use: An LLM coding assistant was used to help audit the compiler diagnostics across the tree, draft the fixes and changelog descriptions, and verify builds and review feedback.
Changes in v4:
- Rebased on v7.4-rc3.
- Patch 2 (powerpc/secvar): Add Reviewed-by from Srish Srinivasan and Acked-by from Madhavan Srinivasan.
- Patch 3 (sh: sq): Add Acked-by from John Paul Adrian Glaubitz.
- Patch 5 (dlm): Clarify subject ("Wait for kobject release before freeing dlm_ls") and update Fixes tag to commit 8a4cf500f1dd ("dlm:
drop kobject release callback handling") (reported by Sashiko).
- Patch 6 (xen/sys-hypervisor): Add Reviewed-by from Juergen Gross.
- Patch 7 (ubifs): Update Fixes tag to commit 2e3cbf425804 ("ubifs:
Export filesystem error counters") (reported by Sashiko).
- Patch 9 (kobject): Drop the "Pre-existing:" comment prefix and explicitly distinguish built-in sites whose storage outlives kobject cleanup (arm64 cpuinfo, ACPI hotplug profiles, s390 sclp_mem) from drivers and tristate modules with broken kobject lifetime management, documenting each lifetime hazard with a FIXME comment for follow-up fixes (requested by Danilo Krummrich).
Changes in v3:
- Rebased on v7.4-rc1.
- Note in cover letter that patches 2 (powerpc/secvar), 3 (sh: sq), and 6 (xen/sys-hypervisor) are still awaiting subsystem Acked-by tags for merging through the driver-core tree, and CC those maintainers on the cover letter.
- Patch 1: Add Reviewed-by from Kees Cook; clarify that LLVM issue #232483 affects Clang versions prior to its upstream fix (pointed out by Nathan Chancellor).
- Patch 4 (cpufreq): Drop obsolete reference to cpufreq_governor_dbs in the commit message per Zhongqiu Han; add Reviewed-by from Zhongqiu Han and Acked-by from Rafael J. Wysocki and Viresh Kumar.
- Patch 5 (dlm): Add Acked-by from Alexander Aring.
- Patch 8 (drm/amdkfd): Add Reviewed-by from Felix Kuehling.
- Patch 9 (kobject): Fix omapfb manager-sysfs.c and overlay-sysfs.c comments to describe managers[] and overlays[] as dynamically allocated rather than static and note the CONFIG_DEBUG_KOBJECT_RELEASE hazard, fix a struct-vs-member wording nit in usnic_ib_sysfs.c, and generalize the commit message note on CONFIG_DEBUG_KOBJECT_RELEASE (reported by Sashiko).
Changes in v2:
- Rebased on v7.3-16928-g83f32c773255 (v7.4 merge window).
- Patch 1: Rename __require_explicit_initialization to __must_init per Greg Kroah-Hartman; document the Clang >= 20 requirement per Miguel Ojeda; note the Clang gap for file-scope objects without an initializer reported by Kees Cook; add tags from v1 and from Kees's posting.
- Move LLM assistance attribution from Assisted-by tags to this cover letter per commit 1e035297ffda ("docs: remove Assisted-by references").
- Patch 4 (cpufreq): Use "cpufreq: governor:" prefix, drop Fixes tag, fix typo, and remove the redundant runtime assignment in cpufreq_dbs_governor_init() per Zhongqiu Han.
- Dropped v1 patch 5 (ACPI: CPPC), already fixed upstream by commit 27954e29d7de ("ACPI: CPPC: Release CPC descriptors through kobject").
- Patch 5 (dlm): Call kobject_del() before dlm_recoverd_stop() in release_lockspace() and the new_lockspace() error path, and wait on a new ls_kobj_done completion before freeing the lockspace or dropping the module reference, avoiding races with delayed kobject release.
- Dropped v1 patch 8 (s390/sclp_mem) per Sumanth Korikkar: the /sys/firmware/memory/memoryX kobjects are permanent, so sclp_mem.c is folded into patch 9 with .release = NULL.
- Patch 7 (ubifs): Add Tested-by and Reviewed-by from Zhihao Cheng.
- Patch 8 (drm/amdkfd): Check q->kobj.state_in_sysfs before kobject_del() in kfd_procfs_del_queue().
- Patch 9 (kobject): Cover sclp_mem.c and the new amdgpu_ualink.c ualink_xcp_info_ktype, fix the overlay-sysfs.c comment, and prefix legacy .release = NULL comments with "Pre-existing:".
- Patch 9 (kobject): The ioat, kunpeng_hccs and omapfb display comments now say that the existing teardown can use-after-free under CONFIG_DEBUG_KOBJECT_RELEASE (reported by Sashiko). Fixing those drivers is left to follow-up patches.
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
[1] https://lpc.events/event/20/contributions/2392/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/
Ian Rogers (9):
Compiler Attributes: Add __must_init macro
powerpc/secvar: Add missing kobject release callback to secvar_ktype
sh: sq: Add missing kobject release callback to ktype_percpu_entry
cpufreq: governor: Initialize kobj_type release callback statically
dlm: Wait for kobject release before freeing dlm_ls xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type
ubifs: sysfs: Use kset_create_and_add() for ubifs_kset drm/amdkfd: Free queue in procfs_queue_type kobject release callback
kobject: Require explicit initialization of struct kobj_type::release
Documentation/conf.py | 1 + arch/arm64/kernel/cpuinfo.c | 7 +++++ arch/powerpc/kernel/secvar-sysfs.c | 6 +++++ arch/sh/kernel/cpu/sh4/sq.c | 6 +++++ drivers/acpi/sysfs.c | 7 +++++ drivers/cpufreq/cpufreq_conservative.c | 5 +++- drivers/cpufreq/cpufreq_governor.c | 4 +-- drivers/cpufreq/cpufreq_governor.h | 1 + drivers/cpufreq/cpufreq_ondemand.c | 5 +++- drivers/dma/ioat/sysfs.c | 8 ++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 8 ++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 17 ++++++++++++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 12 ++++++--- drivers/gpu/drm/amd/amdkfd/kfd_queue.c | 5 +++- drivers/infiniband/hw/hfi1/sysfs.c | 7 +++++ drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++++ drivers/parisc/pdc_stable.c | 8 ++++++ drivers/power/supply/ab8500_fg.c | 8 ++++++ drivers/s390/char/sclp_mem.c | 6 +++++ drivers/soc/hisilicon/kunpeng_hccs.c | 18 +++++++++++++ .../fbdev/omap2/omapfb/dss/display-sysfs.c | 7 +++++ .../fbdev/omap2/omapfb/dss/manager-sysfs.c | 8 ++++++ .../fbdev/omap2/omapfb/dss/overlay-sysfs.c | 7 +++++ drivers/xen/sys-hypervisor.c | 6 +++++ fs/dlm/dlm_internal.h | 1 + fs/dlm/lockspace.c | 26 ++++++++++++++----- fs/erofs/sysfs.c | 14 ++++++++++ fs/f2fs/sysfs.c | 21 +++++++++++++++ fs/ocfs2/cluster/masklog.c | 7 +++++ fs/ubifs/sysfs.c | 24 +++++------------ include/linux/compiler_attributes.h | 12 +++++++++ include/linux/kobject.h | 2 +- scripts/checkpatch.pl | 1 + tools/lib/python/kdoc/xforms_lists.py | 1 + 34 files changed, 251 insertions(+), 32 deletions(-)
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
Signature · 1 line
2.56.1.708.g77570a6a1d-goog