Skip to content

media: rcar-isp: fix core registration and IRQ lifetime

Myeonghun Pak linux-media linux-renesas-soc lkml 2 versions – NAK

Status from this message: Nacked-by: Niklas Söderlund <[email protected]>

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesNAK
  2. v22 patches 1 replySuperseded

Changes in v3 from the cover letter

- Replace the caller's core->base check with -ENODEV to -ENXIO translation at the registration error exit in risp_core_probe().
- Keep resource-setup return values and fallback behavior unchanged.
- Describe patch 1 as a prerequisite for patch 2, without assuming that the existing V4L2 registration helpers return -ENODEV.
- Keep the IRQ lifetime fix in patch 2 unchanged.

Patches in v3

#Subject and filesSizeRepliesApplied
1/2media: rcar-isp: distinguish absent cores from registration failuresdrivers/media/platform/renesas/rcar-isp/core.c+2 -12 replies
2/2media: rcar-isp: release the core interrupt before destroying RPPX1drivers/media/platform/renesas/rcar-isp/core.c drivers/media/platform/renesas/rcar-isp/risp-core.h+11 -40 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchNiklas Söderlund
1/2Nacked-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] media: rcar-isp: fix core registration and IRQ lifetime

The ISP core IRQ is registered before the RPPX1 object and interrupt handler state are initialized. On removal, it remains registered until after RPPX1 has been freed. A handler can therefore access RPPX1 outside its lifetime.

Patch 1 prepares the return-value handling for the later IRQ request in patch 2. It converts registration-stage -ENODEV to -ENXIO after cleanup, so the parent does not mistake that failure for an absent optional core. As requested by Niklas, the caller uses only the return value and does not inspect core->base. Resource-setup results and the existing channel-selector fallback behavior remain unchanged.

Patch 2 requests the IRQ after its dependencies are initialized and releases it before destroying RPPX1. Its code is unchanged from v2.

Compile-tested with Clang 22.1.2, W=1 (arm64). No runtime testing.

Changes in v3:
- Replace the caller's core->base check with -ENODEV to -ENXIO translation at the registration error exit in risp_core_probe().
- Keep resource-setup return values and fallback behavior unchanged.
- Describe patch 1 as a prerequisite for patch 2, without assuming that the existing V4L2 registration helpers return -ENODEV.
- Keep the IRQ lifetime fix in patch 2 unchanged.

Changes in v2:
- Split the error-handling change into patch 1.
- Explain the RPPX1 allocation, free and pre-lock IRQ accesses in patch 2.

v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

Myeonghun Pak (2):
media: rcar-isp: distinguish absent cores from registration failures
media: rcar-isp: release the core interrupt before destroying RPPX1

 drivers/media/platform/renesas/rcar-isp/core.c      | 16 +++++++++++-----
 drivers/media/platform/renesas/rcar-isp/risp-core.h |  2 ++
 2 files changed, 13 insertions(+), 5 deletions(-)

base-commit: 238650ef6c7c7cca08e032527329424c9fbd70e5