Skip to content

crypto: qce - fix self-test issues in skcipher

Bartosz Golaszewski linux-arm-msm linux-crypto lkml stable 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20261016-qce-fixes-skcipher-e0384a650e25

Versions newest first

  1. v12 Latest4 patches 2 repliesIn review
  2. v114 patches 0 repliesSuperseded

Changes in v12 from the cover letter

- Also reject messages shorter than a full block for AES-XTS
- Link to v11: https://patch.msgid.link/[email protected]

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4crypto: qce - Reject messages shorter than a block for AES-XTSdrivers/crypto/qce/skcipher.c+8 -00 replies
2/4crypto: qce - Use a fallback for AES-CTR with a partial final blockdrivers/crypto/qce/skcipher.c+3 -00 replies
3/4crypto: qce - Use fallback for fragmented skcipher payloadsdrivers/crypto/qce/cipher.h drivers/crypto/qce/skcipher.c+12 -20 replies
4/4crypto: qce - Fix xts-aes-qce for weak keysdrivers/crypto/qce/skcipher.c+11 -60 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchKuldeep SinghPankaj Patil
1/4T-b T-b
2/4T-b T-b
3/4T-b T-b
4/4T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 0/4] crypto: qce - fix self-test issues in skcipher

This iteration will hopefully fix the final remaining comment from sashiko.

---
Changes in v12:
- Also reject messages shorter than a full block for AES-XTS
- Link to v11: https://patch.msgid.link/[email protected]

Changes in v11:
- Split out the skcipher patches into a smaller series for easier review
- Drop patch "crypto: qce - Fix CTR-AES for partial block requests" as a
subsequent commit makes this adjustment effectively dead code
- Fix a mid-series build failure due to an earlier bad rebase
- Link to v10: https://patch.msgid.link/[email protected]

Changes in v10:
- don't pass a NULL buffer to sg_init_one()
- fix byte order of the imported hash state on empty finalization
- don't recompute the CTR counter in software for every request
- reject skcipher requests with a too short scatterlist
- check fragmentation for empty CCM decryption requests too
- don't use a static loop iterator (duh...)
- initialize the return value in qce_handle_queue()
- Link to v9: https://patch.msgid.link/[email protected]

Changes in v9:
- Rebase on top of cryptodev/master
- Rephrase Kconfig help text changes
- Link to v8: https://patch.msgid.link/[email protected]

Changes in v8:
- Add a patch making the crypto driver *not* register algos by default
but only if the user explicitly requests it with the provided module
parameter
- Use the "offloader" name for the crypto IP instead of "accelerator"
- Fix device module table issues
- Make the core driver use a list (despite it only having a single
member now) of child auxiliary devices to register to make it clear we
have the intention of extending this once we start the work on secure
media playback
- Link to v7: https://patch.msgid.link/[email protected]

Changes in v7:
- Add follow-up changes converting the QCE crypto driver to auxiliary
bus, adding the core QCE driver under drivers/soc/ registering the
auxiliary device and removing the BROKEN Kconfig label
- Link to v6: https://patch.msgid.link/[email protected]

Changes in v6:
- Handle all zero-length HMAC finalizations (like imported state with
data already hashed), not only the genuinely empty message case
- Add an additional patch addressing the fragmented skcipher payload
issue
- Link to v5: https://patch.msgid.link/[email protected]

Changes in v5:
- Dropped patch 1/8 that's already queued
- Use the pre-allocated fallback ahash for HMAC transforms (Herbert)
- Link to v4: https://patch.msgid.link/[email protected]

Changes in v4:
- Remove remaining ECB and DES3 bits
- Pick up tags
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- Remove even more algorithms and dead code in patch 1/8
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Add fixes for the full suite of crypto self-tests
- Add Fixes and Cc tags
- Link to v1: https://patch.msgid.link/[email protected]/

---
Bartosz Golaszewski (3):
crypto: qce - Reject messages shorter than a block for AES-XTS
crypto: qce - Use a fallback for AES-CTR with a partial final block
crypto: qce - Use fallback for fragmented skcipher payloads

Kuldeep Singh (1):
crypto: qce - Fix xts-aes-qce for weak keys

 drivers/crypto/qce/cipher.h   |  1 +
 drivers/crypto/qce/skcipher.c | 41 +++++++++++++++++++++++++++++++++--------
 2 files changed, 34 insertions(+), 8 deletions(-)

---
base-commit: f0f20b900bbb8bdcfaf6cb282787854067d8eec8
change-id: 20261016-qce-fixes-skcipher-e0384a650e25

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>