riscv64 ptest fixes
Get series with b4
b4 am 20261020155238.1923076-1-40183643+OOHehir@users.noreply.github.comVersions newest first · linked by author and title
- v3 Latest3 patches 0 repliesNew
- v28 patches 3 repliesSuperseded
- v17 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- v2 patches 1-4 & 8 are in master; this resend carries only the tcl patches.
- Patch 1 replaces v2's anchored sed, as Ross Burton suggested: the recipes set SKIPPED_TESTS, which do_install_ptest writes into run-ptest's empty SKIP="", as python3 does. The musl unixInit-3 skip moves there.
- Patch 2 sets SKIPPED_TESTS:append:riscv32 & :riscv64 in place of v2's case on uname -m.
- Patch 3 is unchanged.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tcl, tcl8: set override-specific ptest skips in SKIPPED_TESTSmeta/ meta/ | +12 | 0 replies | |
| 2/3 | tcl, tcl8: skip binary-40.3 on RISC-Vmeta/ meta/ | +8 | 0 replies | |
| 3/3 | ptest-packagelists.inc: re-enable tcl8 for riscv64meta/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] riscv64 ptest fixes
From: OOHehir <[email protected]>
Changes in v3:
- v2 patches 1-4 & 8 are in master; this resend carries only the tcl patches.
- Patch 1 replaces v2's anchored sed, as Ross Burton suggested: the recipes set SKIPPED_TESTS, which do_install_ptest writes into run-ptest's empty SKIP="", as python3 does. The musl unixInit-3 skip moves there.
- Patch 2 sets SKIPPED_TESTS:append:riscv32 & :riscv64 in place of v2's case on uname -m.
- Patch 3 is unchanged.
Patch 2 skips binary-40.3, which expects a negative float NaN to stay negative when widened to double. RISC-V returns the positive canonical NaN, as the ISA requires. Reported on an existing MIPS ticket:
https://core.tcl-lang.org/tcl/tktview/bf029ced86
Testing: tcl & tcl8 built to do_install_ptest_base for qemuriscv32 (glibc), qemuriscv64 (glibc & musl) & qemux86-64 (musl); each installed run-ptest passes dash/busybox -n & checkbashisms, with SKIP set to:
qemuriscv32 glibc " binary-40.3" qemuriscv64 glibc " binary-40.3" qemuriscv64 musl " unixInit-3* binary-40.3" qemux86-64 musl " unixInit-3*"
core-image-ptest-tcl8 testimage, ptest-runner -t 450 (slirp, 4 vCPUs):
qemuriscv64 152 pass, 0 fail, 614 s
qemuriscv32 152 pass, 0 fail, 686 s
Not in this series: tcl8's tcl_package_preprocess mixes tab & space indentation & passes tclConfig.sh to sed twice. I can send a cleanup if that is wanted.
v2: https://lists.openembedded.org/g/openembedded-core/message/248079
OOHehir (3):
tcl, tcl8: set override-specific ptest skips in SKIPPED_TESTS tcl, tcl8: skip binary-40.3 on RISC-V ptest-packagelists.inc: re-enable tcl8 for riscv64
meta/conf/distro/include/ptest-packagelists.inc | 4 ++-- meta/recipes-devtools/tcltk/tcl_9.1.0.bb | 15 ++++++++++----- meta/recipes-devtools/tcltk8/tcl8_8.6.18.bb | 15 ++++++++++----- 3 files changed, 22 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0