Skip to content

PCI/ATS: Disable ATS when ACS TB is set upstream

Danny Gonzalez linux-acpi linux-iommu linux-pci lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v21 patch 2 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- Add patch 1/2 to track IOMMU reset restore state between pci_dev_reset_iommu_prepare() and pci_dev_reset_iommu_done()
- Move the upstream ACS TB check back into pci_ats_supported(), dropping pci_ats_check_acs() and changes to pci-driver.c and pci.h
- Read PCI_ACS_CTRL directly and check the return value and PCI_POSSIBLE_ERROR() so inaccessible bridges are not treated as having PCI_ACS_TB set
- Remove the pci_warn_once() logging and helper function

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iommu: Track whether pci_dev_reset_iommu_done() needs to restore statedrivers/iommu/iommu.c drivers/pci/pci-acpi.c drivers/pci/pci.c +2 more+36 -220 replies
2/2PCI/ATS: Disable ATS when ACS TB is set upstreamdrivers/pci/ats.c+19 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] PCI/ATS: Disable ATS when ACS TB is set upstream

This series disables ATS on endpoints when an upstream bridge has ACS Translation Blocking (PCI_ACS_TB) enabled, preventing ACS Violations on translated DMA requests.

Patch 1/2 stops pci_dev_reset_iommu_done() from re-evaluating pci_ats_supported() and dev_has_iommu() independently from pci_dev_reset_iommu_prepare(), tracking whether state needs to be restored via a @restore output flag instead. It can be merged independently.

Patch 2/2 updates pci_ats_supported() to walk upstream bridges and return false if any bridge has PCI_ACS_TB set in PCI_ACS_CTRL.

Changes since v2:
- Add patch 1/2 to track IOMMU reset restore state between pci_dev_reset_iommu_prepare() and pci_dev_reset_iommu_done()
- Move the upstream ACS TB check back into pci_ats_supported(), dropping pci_ats_check_acs() and changes to pci-driver.c and pci.h
- Read PCI_ACS_CTRL directly and check the return value and PCI_POSSIBLE_ERROR() so inaccessible bridges are not treated as having PCI_ACS_TB set
- Remove the pci_warn_once() logging and helper function

Changes since v1 (v2, based on Sashiko review):
- Move the upstream ACS TB check from pci_ats_supported() into pci_ats_check_acs() called after pci_enable_acs()
- Use pci_acs_enabled() instead of reading PCI_ACS_CTRL directly

Danny Gonzalez (2):
iommu: Track whether pci_dev_reset_iommu_done() needs to restore state PCI/ATS: Disable ATS when ACS TB is set upstream

 drivers/iommu/iommu.c  | 14 ++++++++++----
 drivers/pci/ats.c      | 19 +++++++++++++++++++
 drivers/pci/pci-acpi.c |  5 +++--
 drivers/pci/pci.c      | 25 +++++++++++++++----------
 drivers/pci/quirks.c   |  5 +++--
 include/linux/iommu.h  |  9 +++++----
 6 files changed, 55 insertions(+), 22 deletions(-)
Signature · 1 line
2.56.1.708.g77570a6a1d-goog