Skip to content

crypto - qce: make algos optional and remove the BROKEN label

Bartosz Golaszewski linux-arm-kernel linux-arm-msm linux-crypto lkml stable 1 version In review

Get series with b4
b4 am 20261022-qce-fixes-broken-label-v11-0-0d33c34fd0c3@oss.qualcomm.com change-id 20261022-qce-fixes-broken-label-e6aaf9624fe9

Versions newest first

  1. v11 Latest2 patches 5 repliesIn review

Changes in v11 from the cover letter

- Split out the patches making algorithms optional and removing the
BROKEN Kconfig label into their own series
- Link to v10: https://patch.msgid.link/[email protected]

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: qce - Only register algos if the user really wants itdrivers/crypto/qce/core.c+9 -31 reply
2/2Revert "crypto: qce - Mark QCE as BROKEN"arch/arm/configs/multi_v7_defconfig arch/arm64/configs/defconfig drivers/crypto/Kconfig+15 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKuldeep SinghPankaj PatilBirk SkyumKonrad Dybcio
1/2T-b T-b T-b R-b
2/2T-b T-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v11 thread

Cover letter [PATCH v11 0/2] crypto - qce: make algos optional and remove the BROKEN label

This is the follow-up to the three smaller series fixing crypto self-tests in the QCE driver. It makes the crypto algorithms opt-in via a module parameter and removes the BROKEN label so that the driver is built by default.

The dependencies are:
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/

---
Changes in v11:
- Split out the patches making algorithms optional and removing the
BROKEN Kconfig label into their own series
- Link to v10: https://patch.msgid.link/[email protected]

Changes in v10:
- don't pass a NULL buffer to sg_init_one()
- fix byte order of the imported hash state on empty finalization
- don't recompute the CTR counter in software for every request
- reject skcipher requests with a too short scatterlist
- check fragmentation for empty CCM decryption requests too
- don't use a static loop iterator (duh...)
- initialize the return value in qce_handle_queue()
- Link to v9: https://patch.msgid.link/[email protected]

Changes in v9:
- Rebase on top of cryptodev/master
- Rephrase Kconfig help text changes
- Link to v8: https://patch.msgid.link/[email protected]

Changes in v8:
- Add a patch making the crypto driver *not* register algos by default
but only if the user explicitly requests it with the provided module
parameter
- Use the "offloader" name for the crypto IP instead of "accelerator"
- Fix device module table issues
- Make the core driver use a list (despite it only having a single
member now) of child auxiliary devices to register to make it clear we
have the intention of extending this once we start the work on secure
media playback
- Link to v7: https://patch.msgid.link/[email protected]

Changes in v7:
- Add follow-up changes converting the QCE crypto driver to auxiliary
bus, adding the core QCE driver under drivers/soc/ registering the
auxiliary device and removing the BROKEN Kconfig label
- Link to v6: https://patch.msgid.link/[email protected]

Changes in v6:
- Handle all zero-length HMAC finalizations (like imported state with
data already hashed), not only the genuinely empty message case
- Add an additional patch addressing the fragmented skcipher payload
issue
- Link to v5: https://patch.msgid.link/[email protected]

Changes in v5:
- Dropped patch 1/8 that's already queued
- Use the pre-allocated fallback ahash for HMAC transforms (Herbert)
- Link to v4: https://patch.msgid.link/[email protected]

Changes in v4:
- Remove remaining ECB and DES3 bits
- Pick up tags
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- Remove even more algorithms and dead code in patch 1/8
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Add fixes for the full suite of crypto self-tests
- Add Fixes and Cc tags
- Link to v1: https://patch.msgid.link/[email protected]/

---
Bartosz Golaszewski (2):
crypto: qce - Only register algos if the user really wants it Revert "crypto: qce - Mark QCE as BROKEN"

 arch/arm/configs/multi_v7_defconfig |  1 +
 arch/arm64/configs/defconfig        |  1 +
 drivers/crypto/Kconfig              | 22 +++++++++++++---------
 drivers/crypto/qce/core.c           | 12 +++++++++---
 4 files changed, 24 insertions(+), 12 deletions(-)

---
base-commit: 178aff4cf425b3fc51ff09c571fa1bfbc1eb8ea4
change-id: 20261022-qce-fixes-broken-label-e6aaf9624fe9
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: 7c93b8489dbf6d4edf932389c4c931d897f38ec2
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: d3f97f2fcbc99093e51f4b749eda4c2d0cff4e92
prerequisite-patch-id: 7c4695a73eaad5db182edb09a608c6bc51883c82
prerequisite-patch-id: f3743392de54aa4ce3da76d11637dfeedb922b3a
prerequisite-patch-id: 02e9caf718743f7860aa19031e6809bdd718878e
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: 4764101927c437b38d71379f95b98c82a20a48ca
prerequisite-patch-id: e918a7b007c3a1b88b526fdf7865b811155deceb
prerequisite-patch-id: 8aba9f114cc43e24c8568caf5ca4e7bb82e54b67

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>