drm/rockchip: vop2: Add 8K support for RK3588 vop2
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 0 repliesNew
- v23 patches 0 repliesSuperseded
- v13 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- Link to v2: https://lore.kernel.org/all/[email protected]/
- Cast the result of drm_format_info_min_pitc() to u32 to avoid 64bit division.
- Rework the left-window splice check to avoid pulling an unrelated CRTC into non-modeset commits, and use the new CRTC mode instead of the stale splice_mode flag(Sashiko).
- Reserve the splice partner window when the partner VP has no CRTC, so it cannot be assigned as another VP's primary plane(Sashiko).
- Only set the partner VP's CFG_DONE while the new state is in splice mode; do not force it when leaving splice mode(Sashiko).
- Program the main and splice video ports in a single layer-mixer pass, and apply the YUV overlay mode to both VPs(Sashiko).
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drm/rockchip: vop2: Use drm_format_info_min_pitch() for plane offsetsdrivers/ | +2 | 0 replies | |
| 2/3 | drm/rockchip: vop2: Skip UV plane setup for packed YUV formatsdrivers/ | +2 | 0 replies | |
| 3/3 | drm/rockchip: vop2: Support 8K output by splicing two video portsdrivers/ drivers/ drivers/ +1 more | +853 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] drm/rockchip: vop2: Add 8K support for RK3588 vop2
From: Chaoyi Chen <[email protected]>
Hi,
This series adds support for 8K output on the RK3588 VOP2. HDMI is not ready yet, but I believe many people might be interested in this.
8K output on the RK3588 is done by splicing two VPs together, with VP0 outputting the left half of the screen and VP1 the right half. In addition, 8K planes have to be split in half as well to stay within the width limit of a single plane. Similarly, there are a few post-processing details that need to be handled.
Note that splice mode is not only usable for 8K output. This means the mode can be tested at 4K and even lower resolutions, by simply changing this one line:
-#define VOP2_MAX_VP_OUTPUT_WIDTH 4096
+#define VOP2_MAX_VP_OUTPUT_WIDTH (3840 / 2) /* for 4K test */
And yes, this has been tested at 4K over HDMI on the RK3588 EVB1 :)
Changes in v3:
- Link to v2: https://lore.kernel.org/all/[email protected]/
- Cast the result of drm_format_info_min_pitc() to u32 to avoid 64bit division.
- Rework the left-window splice check to avoid pulling an unrelated CRTC into non-modeset commits, and use the new CRTC mode instead of the stale splice_mode flag(Sashiko).
- Reserve the splice partner window when the partner VP has no CRTC, so it cannot be assigned as another VP's primary plane(Sashiko).
- Only set the partner VP's CFG_DONE while the new state is in splice mode; do not force it when leaving splice mode(Sashiko).
- Program the main and splice video ports in a single layer-mixer pass, and apply the YUV overlay mode to both VPs(Sashiko).
Changes in v2:
- Link to v1: https://lore.kernel.org/all/[email protected]/
- Missing removal of the replaced line(Heiko).
- vop2_win_get_pstate(): use the left window's state only in splice mode(Sashiko).
- Reject splice windows already in use by another CRTC(Sashiko).
- Check the splice partner via drm_atomic_get_crtc_state() instead of the runtime flag and unlocked read(Sashiko).
- Set splice_mode_right/left_vp before the error paths of vop2_crtc_atomic_enable()(Sashiko).
- Validate each split half against the min width 4 and max input width; align NV20/NV30 like NV15(Sashiko).
- Latch overlay registers at the left VP's vsync; don't wait for the partner's own cfg-done(Sashiko).
- Program the color key on the window actually being updated(Sashiko).
Chaoyi Chen (3):
drm/rockchip: vop2: Use drm_format_info_min_pitch() for plane offsets drm/rockchip: vop2: Skip UV plane setup for packed YUV formats drm/rockchip: vop2: Support 8K output by splicing two video ports
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 5 + drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 579 +++++++++++++++++-- drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 66 ++- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 370 ++++++++---- 4 files changed, 857 insertions(+), 163 deletions(-)
Signature · 1 line
2.53.0