Skip to content

xe/shaders: remove explicit regioning and channel offsets

Andrzej Hajda igt-dev 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20261027-remove_gpu_asm_annotations-94b7b32841dd

Versions newest first

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v11 patch 0 repliesSuperseded

Changes in v3 from the cover letter

- changed formating of args from single-space separated to tab aligned (Zbigniew)
- Link to v2: https://patch.msgid.link/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/shaders: remove explicit regioning and channel offsetslib/gpgpu_fill.c lib/gpgpu_fill.c.gen.iga64_codes.c lib/gpgpu_shader.c +2 more+147 -1471 reply
2/2tests/intel/xe_prefetch_fault: remove explicit regioning and channel offsetstests/intel/xe_prefetch_fault.c tests/intel/xe_prefetch_fault.c.gen.iga64_codes.c+9 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchZbigniew Kempczyński
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] xe/shaders: remove explicit regioning and channel offsets

There is no need to specify regioning and channel offset in
most cases. Default genisa values are:
- <0;1,0> for source region,
- <1> for destination region,
- M0 for channel offset.
The patch also enforces common formating for all asms:
- preprocessor instructions and predicates start from beginning of the line,
- instruction mnemonic starts from 1st tab,
- exec size follows mnemonic after one space,
- flag modifiers, if any, are placed after exec size,
- arguments starts from 3rd tab,
- args are tab aligned per shader - argN should be place at the same column

The changes do not affect produced binary code.

---
Changes in v3:
- changed formating of args from single-space separated to tab aligned (Zbigniew)
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- split patch to lib and test parts, remove script change (Kamil)
- Link to v1: https://patch.msgid.link/[email protected]

---
Andrzej Hajda (2):
lib/shaders: remove explicit regioning and channel offsets tests/intel/xe_prefetch_fault: remove explicit regioning and channel offsets

 lib/gpgpu_fill.c                                  | 100 ++++++++--------
 lib/gpgpu_fill.c.gen.iga64_codes.c                |   2 +-
 lib/gpgpu_shader.c                                | 132 +++++++++++-----------
 lib/gpgpu_shader.c.gen.iga64_codes.c              |   2 +-
 lib/iga64_macros.h                                |  58 +++++-----
 tests/intel/xe_prefetch_fault.c                   |  16 +--
 tests/intel/xe_prefetch_fault.c.gen.iga64_codes.c |   2 +-
 7 files changed, 156 insertions(+), 156 deletions(-)

---
base-commit: 45b7aef25da3a40ae4cc75442d7b8e6f9af1fb98
change-id: 20261027-remove_gpu_asm_annotations-94b7b32841dd

Best regards,

Signature · 1 line
Andrzej Hajda <[email protected]>