arm64: dts: qcom: Add Xiaomi Poco M3 (citrus)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 3 repliesIn review
- v22 patches 9 repliesSuperseded
- v12 patches 1 replySuperseded
Changes in v3 from the cover letter
- Split lemon into sm6115-xiaomi-lime-common.dtsi and add citrus on top of it (Barnabas). The IPA carve-outs are in the common dtsi.
- Fixed the unit addresses of the IPA and GPU reserved-memory nodes (Sashiko).
- Split the card detect pinctrl of the microSD slot into separate states, as lemon does. The pin configuration is unchanged.
- Kept the ADSP carve-out per variant. A larger range common to both works on citrus (tested), as Barnabas suggested, but wastes 4 MiB of RAM, as Konrad pointed out. I did not touch lemon's value because I cannot test it.
- Kept the deletion of cdsp_sec_mem and of the orientation-switch property of usb_qmpphy in citrus, as in v2, since that is the tested configuration. Barnabas suggested they may be leftovers from the reference design. I will test dropping them and follow up.
- Dropped Konrad's Reviewed-by on patch 3 because of the rework. Krzysztof's Acked-by on patch 1 is kept.
- Clarified in the commit message that the GPU is enabled but not usable without the display pipeline.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | dt-bindings: arm: qcom: Document Xiaomi Poco M3Documentation/ | +1 | 0 replies | |
| 2/3 | arm64: dts: qcom: sm6115-xiaomi-lemon: Split out a common dtsiarch/ arch/ | +336 | 3 replies | |
| 3/3 | arm64: dts: qcom: Add Xiaomi Poco M3arch/ arch/ | +238 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski |
|---|---|
| 1/3 | A-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] arm64: dts: qcom: Add Xiaomi Poco M3 (citrus)
This series adds initial support for the Xiaomi Poco M3 (codename citrus), a smartphone based on the Qualcomm Snapdragon 662 (SM6115). As suggested by Barnabas, the shared parts of lemon are moved into a common dtsi, and citrus is added on top of it. The series is based on v7.4-rc1.
Currently working on citrus:
- UFS and microSD
- USB host (OTG), limited to high-speed (SuperSpeed is untested)
- WiFi
- Bluetooth
- Remoteprocs (ADSP, CDSP and modem)
Not included yet: the display panel, touchscreen and the display pipeline, which depend on drivers that are not upstream. The GPU and its zap shader are enabled, but no DRM device is registered without the display subsystem, so the GPU is not usable with this series alone. Audio is not included either.
Firmware and userspace: WiFi, Bluetooth, the remoteprocs and the GPU zap shader need device-specific firmware which is not part of this series. WiFi additionally needs qrtr, tqftpserv and rmtfs running in userspace, and the Bluetooth controller needs its BD address set from userspace.
Testing: citrus was tested on a Poco M3 booted from microSD with a v7.2-based kernel. I do not own a Redmi 9T, so lemon is untested on hardware. Instead, I compared the lemon DTS before and after the split, normalized with dtc (dtc -I dts -O dts -s). The only difference is the numbering of auto-generated phandles.
Changes in v3:
- Split lemon into sm6115-xiaomi-lime-common.dtsi and add citrus on top of it (Barnabas). The IPA carve-outs are in the common dtsi.
- Fixed the unit addresses of the IPA and GPU reserved-memory nodes (Sashiko).
- Split the card detect pinctrl of the microSD slot into separate states, as lemon does. The pin configuration is unchanged.
- Kept the ADSP carve-out per variant. A larger range common to both works on citrus (tested), as Barnabas suggested, but wastes 4 MiB of RAM, as Konrad pointed out. I did not touch lemon's value because I cannot test it.
- Kept the deletion of cdsp_sec_mem and of the orientation-switch property of usb_qmpphy in citrus, as in v2, since that is the tested configuration. Barnabas suggested they may be leftovers from the reference design. I will test dropping them and follow up.
- Dropped Konrad's Reviewed-by on patch 3 because of the rework. Krzysztof's Acked-by on patch 1 is kept.
- Clarified in the commit message that the GPU is enabled but not usable without the display pipeline.
Open questions, mainly for Adam:
- lemon's GPU carve-out is 0xfa400000, citrus uses 0x55a15000 (right after pil_ipa_gsi_mem). Is the lemon value intentional?
- lemon's ADSP carve-out is 0x53400000/0x2600000. Barnabas reported that lemon's stock layout (from MIUI sysfs) starts at 0x53800000. If lemon also works with 0x53800000/0x2200000, the node could move to the common dtsi in a follow-up.
- lemon marks l5, l7 and l22 as always-on, citrus does not need it. Is it needed on lemon?
Link to v1:
https://lore.kernel.org/linux-arm-msm/[email protected]/
Link to v2:
https://lore.kernel.org/linux-arm-msm/[email protected]/
Amir Hanip (3):
dt-bindings: arm: qcom: Document Xiaomi Poco M3
arm64: dts: qcom: sm6115-xiaomi-lemon: Split out a common dtsi
arm64: dts: qcom: Add Xiaomi Poco M3
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6115-xiaomi-citrus.dts | 237 +++++++++++++ .../boot/dts/qcom/sm6115-xiaomi-lemon.dts | 317 +---------------- .../dts/qcom/sm6115-xiaomi-lime-common.dtsi | 335 ++++++++++++++++++ 5 files changed, 575 insertions(+), 316 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sm6115-xiaomi-citrus.dts create mode 100644 arch/arm64/boot/dts/qcom/sm6115-xiaomi-lime-common.dtsi
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
Signature · 1 line
2.47.3