RFC add provenance time (ptime)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest10 patches 53 repliesIn review
- v3 RFC5 patches 32 repliesSuperseded
- v2 RFC2 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 2 patches | 4 replies | Superseded |
Changes in v4 from the cover letter
- vfs: implement fsx_xflags_mask as suggested by Amir Goldstein[6];
- add SMB (ksmbd/cifs) and nfs (nfsd/nfs) support as requested in previous threads;
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | vfs: add provenance time (ptime)fs/ fs/ include/ +3 more | +95 | 2 replies | |
| 2/10 | vfs: add fileattr_has_fsx_mask()include/ | +18 | 2 replies | |
| 3/10 | ntfs3: make crtime user-settable using ptimefs/ fs/ | +25 | 2 replies | |
| 4/10 | exfat: make crtime user-settable using ptimefs/ fs/ fs/ | +44 | 0 replies | |
| 5/10 | btrfs: add provenance time (ptime)fs/ fs/ fs/ +4 more | +67 | 0 replies | |
| 6/10 | vfs: add __vfs_fileattr_set_locked() for inode_lock()'d callersfs/ include/ | +86 | 2 replies | |
| 7/10 | nfsd: add provenance time (ptime) via FATTR4_TIME_CREATEfs/ fs/ fs/ +2 more | +57 | 8 replies | |
| 8/10 | nfs: add provenance time (ptime) via FATTR4_TIME_CREATEfs/ fs/ fs/ +3 more | +93 | 7 replies | |
| 9/10 | ksmbd: add provenance time (ptime) and map it to CreationTimefs/ fs/ fs/ | +64 | 6 replies | |
| 10/10 | cifs: add provenance time (ptime) and map it to SMB's CreationTimefs/ fs/ fs/ | +94 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [RFC PATCH v4 00/10] add provenance time (ptime)
This is an initial implementation of a new timestamp to indicate the time when a file/directory was initially created.
This patch series takes inspiration from the one by Sean Smith <[email protected]> [1], but using file_setattr()/file_getattr() as suggested by Darrick J. Wong <[email protected]> in [2].
The semantics of this new timestamp should be at least these:
- it should be the same as btime on a newly created file
- it's user-settable, so it can be preserved for backups, filesystem conversions, archives and any similar operation
- it should be preserved every time mtime gets preserved
and the correspondence with the other timestamps is as follows:
ctime <-> btime
mtime <-> ptime
Examples:
1) a .zsh_history file created in 2019, then after a few years the user decides to switch to another filesystem, copying the .zsh_history to the new home, in that case btime would have the timestamp of the copy and ptime would have the 2019 timestamp (just like mtime would have been preserved)
2) a symlink created in 2020 from the home directory to a /path going through the same process as the .zsh_history, in this case it would also make sense to sync the ptime to the 2020 timestamp instead of keeping only the btime (so the inode creation time).
The proof-of-concept code (for testing) for stat(1) and cp(1) is available at https://github.com/koraynilay/coreutils (master branch) (Note: these coreutils code changes are a prototype and won't be submitted upstream as-is, but they work as expected in simple stat and cp -a/--preserve=ptime tests)
Lastly, the name "provenance" and "ptime" are not final, I personally don't have a strong opinion on any name, but while testing with stat(1) I noticed that "Provenance" is definitely too long for the normal output, so another option which would fit well is "Origin time", abbreviated as "ntime" (OrigiN time) and not as "otime", as that would conflict with btrfs' internal naming and create confusion.
v2 changes:
- fix permission bypass leading to ptime update on immutable and append-only files (found by sashiko[3])
- normalize ptime timestamp as done in fs/attr.c:notify_change() (found by sashiko[3])
- fix wording in vfs patch to be like the cover-letter
v3 changes:
- vfs: reject setting ptime with -EOPNOTSUPP on filesystems that do not support it instead of silently ignoring it (found by sashiko[4])
- vfs: fix not being able to clear immutable and append-only on files with ptime, and allow updating immutable/append-only atomically along with ptime (found by sashiko[4])
- btrfs: validate on-disk ptime nanoseconds and reset to otime if invalid (found by sashiko[4])
- btrfs: avoid re-assigning ptime on unrelated chattr calls (found by sashiko[4])
- add ntfs3 and exfat support as suggested by Amir Goldstein[5], but no vfat, smb, or nfs4 yet as they are a bit more complex
- move the introduction of fileattr_has_fsx_mask() from the btrfs patch to a standalone patch in the series
- btrfs: add fileattr_[gs]et to symlink and special file operations
v4 changes:
- vfs: implement fsx_xflags_mask as suggested by Amir Goldstein[6];
- add SMB (ksmbd/cifs) and nfs (nfsd/nfs) support as requested in previous threads;
Note:
to apply this patch 2 previous patches[7][8] from the ksmbd/cifs subsystem are needed.
New Question:
should I rename fileattr_has_fsx_mask() to something like fileattr_has_unsupported_fsx() and keep its code as-is, or should I add the fsx_xflags_mask & ~allowed check in it and keep the name as-is? (or both?)
Thanks.
[1]: https://lore.kernel.org/[email protected]
[2]: https://lore.kernel.org/20260407014129.GC6192@frogsfrogsfrogs
[3]: https://sashiko.dev/#/patchset/20261027220532.736352-1-koray.fra%40gmail.com
[4]: https://sashiko.dev/#/patchset/20261028134728.294127-1-koray.fra%40gmail.com
[5]: https://lore.kernel.org/CAOQ4uxiuy0VwZj+3M-zRqQ49WTpHZpiaQ+6MZ8z8WdLjyQM_zA@mail.gmail.com/
[6]: https://lore.kernel.org/CAOQ4uxjtuTDT63vJdYaq+RHQEQFLTksp66e46OMN99WhJz3SbA@mail.gmail.com/
[7]: https://lore.kernel.org/linux-cifs/[email protected]/
[8]: https://lore.kernel.org/linux-cifs/[email protected]/
koraynilay (10):
vfs: add provenance time (ptime)
vfs: add fileattr_has_fsx_mask()
ntfs3: make crtime user-settable using ptime
exfat: make crtime user-settable using ptime
btrfs: add provenance time (ptime)
vfs: add __vfs_fileattr_set_locked() for inode_lock()'d callers
nfsd: add provenance time (ptime) via FATTR4_TIME_CREATE
nfs: add provenance time (ptime) via FATTR4_TIME_CREATE
ksmbd: add provenance time (ptime) and map it to CreationTime
cifs: add provenance time (ptime) and map it to SMB's CreationTime
fs/btrfs/btrfs_inode.h | 4 + fs/btrfs/delayed-inode.c | 6 ++ fs/btrfs/inode.c | 29 +++++- fs/btrfs/ioctl.c | 24 ++++- fs/btrfs/print-tree.c | 1 + fs/btrfs/tree-log.c | 3 + fs/exfat/exfat_fs.h | 2 + fs/exfat/file.c | 42 ++++++++- fs/exfat/namei.c | 1 + fs/file_attr.c | 156 ++++++++++++++++++++++++++------ fs/nfs/inode.c | 27 +++++- fs/nfs/internal.h | 2 + fs/nfs/nfs4proc.c | 56 +++++++++++- fs/nfs/nfs4xdr.c | 19 ++-- fs/nfs/symlink.c | 1 + fs/nfsd/nfs4proc.c | 9 ++ fs/nfsd/nfs4xdr.c | 40 +++++--- fs/nfsd/vfs.c | 17 ++++ fs/nfsd/vfs.h | 4 +- fs/nfsd/xdr4.h | 3 + fs/ntfs3/file.c | 20 +++- fs/ntfs3/frecord.c | 8 +- fs/smb/client/cifsfs.c | 8 ++ fs/smb/client/inode.c | 7 +- fs/smb/client/ioctl.c | 109 ++++++++++++++++------ fs/smb/server/smb2pdu.c | 37 +++++--- fs/smb/server/vfs.c | 43 ++++++++- fs/smb/server/vfs.h | 1 + fs/stat.c | 2 + include/linux/fileattr.h | 29 +++++- include/linux/nfs_xdr.h | 3 + include/linux/stat.h | 1 + include/uapi/linux/btrfs_tree.h | 3 +- include/uapi/linux/fs.h | 9 +- include/uapi/linux/stat.h | 7 +- 35 files changed, 614 insertions(+), 119 deletions(-)
base-commit: 3bc1fb9c3b20cd478c83496ab16addecb401770d
prerequisite-patch-id: 049ae0eba275b5be35a238833107e0b251a55aa2
prerequisite-patch-id: 614f0bc9411391403d4e9702bafeb31b0ec04ec1
prerequisite-patch-id: ddf636b9d33d82ea206ce265d817371350bf8858
Signature · 1 line
2.56.0