scsi: Bind sd to LUs in the ALUA unavailable state
Status from this message: Applied to 7.5/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 5 repliesApplied
- v24 patches 0 repliesSuperseded
- v14 patches 0 repliesSuperseded
Changes in v3 from the cover letter
- Dropped 3/4, which started a new port group in scsi_dh_alua in the access state read at scan. alua_bus_attach() calls alua_initialize() before it sets sdev->handler_data, so the initial RTPG that alua_check_vpd() queues is not scheduled, and alua_prep_fn() would keep failing I/O to a path that had since recovered until something else queued an RTPG. scsi_dh_alua is no longer changed apart from calling scsi_report_tpgs().
- 2/3: The commit message no longer says that the handler queues an RTPG when it attaches.
- 1/3, 3/3: No changes.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi: core: Move REPORT TARGET PORT GROUPS into the SCSI coredrivers/ drivers/ include/ +1 more | +73 | 1 reply | |
| 2/3 | scsi: core: Read the ALUA access state when a device is scanneddrivers/ | +94 | 1 reply | |
| 3/3 | scsi: core: Match ULDs to logical units in the ALUA unavailable statedrivers/ drivers/ include/ | +40 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] scsi: Bind sd to LUs in the ALUA unavailable state
A LU that is in the ALUA unavailable state on a target port reports peripheral qualifier 001b in its INQUIRY data. scsi_bus_match() only matches devices with peripheral qualifier 000b, so if a host scans such a path, no upper-level driver is ever bound to it. When the target port later becomes available, nothing binds sd and the path stays unusable until the device is deleted and rescanned. A host that was already running when the path became unavailable keeps sd bound, so the result depends on when the host scanned.
This series fixes that at scan time. The SCSI core reads the ALUA access state of a device with REPORT TARGET PORT GROUPS before the device is registered, and matches sd to PQ 001b devices whose access state could be read. SPC-4 requires PQ 001b in the unavailable state, and the command fails for an unmapped LUN, so these are taken to be mapped LUs that are unavailable. This is the same situation as a path in the standby state, to which sd already binds. The path then stays in the multipath map as a failed path, and the existing UNIT ATTENTION handling brings it back when the target port becomes available.
PQ 001b cannot be matched on its own: an unmapped LUN reports it as well, and some targets report every possible LUN in REPORT LUNS. Binding sd to all of those would create disks with no backing LU. An unmapped LUN fails REPORT TARGET PORT GROUPS, so the access state is what tells the two cases apart.
1/3 moves submit_rtpg() out of scsi_dh_alua into the SCSI core as
scsi_report_tpgs(), so the core can read the ALUA state of a device itself. No functional change.
2/3 sends REPORT TARGET PORT GROUPS from scsi_add_lun() for a device
that reports TPGS support and sets sdev->access_state from the descriptor of the target port group of this path.
3/3 matches PQ 001b devices whose access state could be read, which
are taken to be mapped LUs in the unavailable state.
This is an alternative to the series that refreshes the INQUIRY data and reprobes the device on rescan ("scsi: Refresh INQUIRY data and reprobe on rescan", v8 last posted). That series needs a way to update the INQUIRY data of a live device and to reprobe it. This one does not change the INQUIRY data after the device is discovered, and has no reprobe, so none of the locking and ordering issues that came with refreshing it.
The INQUIRY data in sysfs is unchanged by this series. It is read and created once, when the device is discovered, and keeps the peripheral qualifier reported at that time like the rest of the INQUIRY data. At any given time that cached peripheral qualifier can be out of sync with the device, for example after the target port moves between available and unavailable. An INQUIRY sent to the device returns the current value, and the access_state attribute shows the current ALUA state.
This does not make every target work. Today none does: a host that scans a path while it is unavailable never binds sd to it. With this series a target that answers sd's probe commands in that state is handled correctly, and the others are no worse off. What it relies on, and the known limits:
- SPC-4 requires PQ 001b in the unavailable state and requires REPORT TARGET PORT GROUPS there. It does not say that PQ 001b is reported only in that state, so a PQ 001b device whose access state could be read is taken to be a mapped LU that is unavailable: an unmapped LUN fails the command.
- The decision is made once, at scan, like the peripheral qualifier itself. If REPORT TARGET PORT GROUPS fails (other than with UNIT ATTENTION, which is retried), or the INQUIRY data and VPD page 0x83 do not allow it to be sent, nothing is matched, as before.
- SPC-4 requires neither READ CAPACITY nor, in the unavailable state, MODE SENSE. sd's probe commands are sent to the target. If a target rejects them, sd keeps default values, such as a capacity of 0, until a later revalidate, as it does for a standby path today. If the path changes state while sd probes, it can also end up with a mix.
- The ALUA device handler is unchanged and treats a new port group as active/optimized until it learns the state, so the first regular I/O to an unavailable path, e.g. the partition table read, can fail with LOGICAL UNIT NOT ACCESSIBLE, TARGET PORT IN UNAVAILABLE STATE. A path in the standby state already does the same with TARGET PORT IN STANDBY STATE.
- The standard INQUIRY data, including the peripheral qualifier and what sd uses from it, is only read when the device is discovered; the kernel has no mechanism to refresh it. A rescan, e.g. on the INQUIRY DATA HAS CHANGED UNIT ATTENTION, reads the VPD pages again and revalidates sd, but does not read the INQUIRY data again.
Changes since v2 (prompted by the Sashiko review of 3/4):
- Dropped 3/4, which started a new port group in scsi_dh_alua in the access state read at scan. alua_bus_attach() calls alua_initialize() before it sets sdev->handler_data, so the initial RTPG that alua_check_vpd() queues is not scheduled, and alua_prep_fn() would keep failing I/O to a path that had since recovered until something else queued an RTPG. scsi_dh_alua is no longer changed apart from calling scsi_report_tpgs().
- 2/3: The commit message no longer says that the handler queues an RTPG when it attaches.
- 1/3, 3/3: No changes.
Changes since v1 (prompted by the Sashiko review of 4/4):
- 4/4: scsi_bus_match() no longer tests sdev->access_state. The peripheral qualifier is read once when the device is scanned, but access_state follows the ALUA state, so a device scanned in the unavailable state stopped matching as soon as its path became
available: when an upper-level driver module is loaded later, when a driver is rebound through sysfs, or when the ALUA device handler updated access_state before sd was probed. scsi_add_lun() now records in a new sdev->match_unavailable flag whether the device reported PQ 001b and its access state could be read, and scsi_bus_match() uses that. SPC-4 requires PQ 001b in the unavailable state and an unmapped LUN fails the command, so this does not depend on the state the command returns, which can already be available if the path recovered between the INQUIRY and the command.
- 1/4 to 3/4: No changes.
v2 cover-letter Message-ID: <[email protected]> v1 cover-letter Message-ID: <[email protected]>
Brian Bunker (3):
scsi: core: Move REPORT TARGET PORT GROUPS into the SCSI core
scsi: core: Read the ALUA access state when a device is scanned
scsi: core: Match ULDs to logical units in the ALUA unavailable state
drivers/scsi/device_handler/scsi_dh_alua.c | 63 +++--------- drivers/scsi/scsi_lib.c | 52 ++++++++++ drivers/scsi/scsi_scan.c | 110 +++++++++++++++++++++ drivers/scsi/scsi_sysfs.c | 14 ++- include/scsi/scsi_device.h | 9 ++ include/scsi/scsi_proto.h | 3 + 6 files changed, 202 insertions(+), 49 deletions(-)
Signature · 1 line
2.56.0