ionic: make the device command timeout configurable
Get series with b4
b4 am [email protected] change-id 20261102-b4-ionic-cmd-timeout-c704d5304b4fVersions newest first
- v3 Latest3 patches 0 repliesNew
- v23 patches 3 repliesSuperseded
- v13 patches 1 replySuperseded
Changes in v3 from the cover letter
- patch 3:
- register the parameter once at probe, on PFs only, instead of
unregistering it on firmware and PCI resets and registering it
again on restart
- get reports the value read at the last probe or reset, or stored by
a later set, instead of sending a device command
- keep the timeout in use when reading the stored value fails,
instead of falling back to the default
- read the stored value right after identify at probe and PCI reset,
so the remaining commands there use it
- rebase on net-next
- Link to v2: https://patch.msgid.link/[email protected]
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ionic: make the command timeout per devicedrivers/ drivers/ drivers/ +6 more | +47 | 0 replies | |
| 2/3 | RDMA/ionic: Use the ionic command timeout for the admin queuedrivers/ | +6 | 0 replies | |
| 3/3 | ionic: add devlink param for command timeoutDocumentation/ drivers/ drivers/ +7 more | +187 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Brett Creeley | Allen Hubbe |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | R-b | A-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/3] ionic: make the device command timeout configurable
ionic waits a fixed 5 seconds for device and admin queue commands, and the RDMA driver gives its admin queue 2 seconds. Some commands can take the firmware longer than that, for example while a PFC configuration change flaps the links. The firmware is alive but slow, yet the timed-out command and everything queued behind it fail, and an RDMA admin queue timeout resets the RDMA LIF so that later verbs fail with -ENODEV.
Patch 1 makes the timeout a per-device value without changing it. Patch 2 has the RDMA admin queue use the ionic command timeout instead of its own 2 seconds.
Patch 3 adds a permanent devlink parameter, cmd_timeout, on each PF. The firmware stores the value per PF in NVM, and the PF and its VFs read it at probe and after a reset.
Tested on an AMD Pensando adapter under KASAN and lockdep: get and set of the parameter, and the stored value read back after an FLR.
Patch 2 conflicts with "RDMA/ionic: Wait the device command timeout for admin queue commands", sent to rdma for-rc:
https://patch.msgid.link/[email protected]
When both are merged, keep this series' version: ionic_admin_timeout() replaces IONIC_ADMIN_TIMEOUT, and already defaults to 5 seconds.
This series was developed with the help of an LLM-based coding assistant (Claude).
---
Changes in v3:
- patch 3:
- register the parameter once at probe, on PFs only, instead of
unregistering it on firmware and PCI resets and registering it
again on restart
- get reports the value read at the last probe or reset, or stored by
a later set, instead of sending a device command
- keep the timeout in use when reading the stored value fails,
instead of falling back to the default
- read the stored value right after identify at probe and PCI reset,
so the remaining commands there use it
- rebase on net-next
- Link to v2: https://patch.msgid.link/[email protected]
Changes in v2:
- patch 3:
- comment in ionic_dl_cmd_timeout_get() on why it has no FW_RESET check
- changelog "after probe or reset" -> "after probe or PCI reset"
- Link to v1: https://patch.msgid.link/[email protected]
---
Arun Kumar Prakash (3):
ionic: make the command timeout per device RDMA/ionic: Use the ionic command timeout for the admin queue
ionic: add devlink param for command timeout
Documentation/networking/devlink/ionic.rst | 27 ++++++++ drivers/infiniband/hw/ionic/ionic_admin.c | 9 ++- drivers/net/ethernet/pensando/ionic/ionic.h | 10 ++- drivers/net/ethernet/pensando/ionic/ionic_api.h | 8 +++ drivers/net/ethernet/pensando/ionic/ionic_aux.c | 8 ++- .../net/ethernet/pensando/ionic/ionic_bus_pci.c | 3 + drivers/net/ethernet/pensando/ionic/ionic_dev.c | 70 ++++++++++++++++++-- drivers/net/ethernet/pensando/ionic/ionic_dev.h | 2 + .../net/ethernet/pensando/ionic/ionic_devlink.c | 77 ++++++++++++++++++++++ .../net/ethernet/pensando/ionic/ionic_ethtool.c | 12 ++-- drivers/net/ethernet/pensando/ionic/ionic_fw.c | 8 +-- drivers/net/ethernet/pensando/ionic/ionic_if.h | 8 +++ drivers/net/ethernet/pensando/ionic/ionic_lif.c | 11 ++-- drivers/net/ethernet/pensando/ionic/ionic_main.c | 17 ++--- 14 files changed, 236 insertions(+), 34 deletions(-)
---
base-commit: 44454974aef9c81949e5858ed3e8cbd08e104cad
change-id: 20261102-b4-ionic-cmd-timeout-c704d5304b4f
Best regards,
Signature · 1 line
Nikhil P. Rao <[email protected]>