Add LE connection parameters to org.bluez.Bearer.LE1
Status from this message: This series was applied to bluetooth/bluez.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | doc/mgmt: Document Connection Subrate for LE connections and updatesdoc/ | +7 | 1 reply | |
| 2/5 | org.bluez.Bearer: Add connection parameter propertiesdoc/ | +38 | 0 replies | |
| 3/5 | bearer: Add connection parameter propertiessrc/ src/ src/ +2 more | +148 | 0 replies | |
| 4/5 | client: Print LE connection parameters in infoclient/ | +5 | 0 replies | |
| 5/5 | test: functional: add bearer connection parameter testsdoc/ test/ | +121 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH BlueZ 0/5] Add LE connection parameters to org.bluez.Bearer.LE1
Applications have no way to know the parameters of an LE connection:
the interval, peripheral latency and supervision timeout. They decide how fast data can move and how quickly a lost link is noticed, so applications that need them end up reading them from HCI traffic.
This adds Interval, Latency, SupervisionTimeout and Subrate properties to org.bluez.Bearer.LE1, filled from the MGMT Connection Subrate event, which bluetoothd already registers but only logs. With "Bluetooth: MGMT:
Send Connection Subrate on LE connection and update", now in bluetooth-next, the kernel sends that event when an LE connection is established and after each LE Connection Update, not only on LE Connection Rate Change.
The properties are only present while connected over LE. Interval is in microseconds, as with Shorter Connection Intervals it is no longer a multiple of 1.25 ms, and SupervisionTimeout is in milliseconds. They are not marked experimental, since the tests come with them, but I can mark them so if you prefer. There is no command to read the parameters, so when bluetoothd starts while a device is already connected over LE, the properties only appear once the parameters change.
The two new functional tests check that both hosts report the parameters once connected, follow a connection update the peripheral asks for, and drop them on disconnection. On bluetooth-next the bearer tests pass in 3 of 3 runs; without the kernel patch the new tests fail. make check and the functional tests using HoG, btmgmt, bluetoothctl or the agent pass.
Kevin Dewald (5):
doc/mgmt: Document Connection Subrate for LE connections and updates org.bluez.Bearer: Add connection parameter properties
bearer: Add connection parameter properties
client: Print LE connection parameters in info
test: functional: add bearer connection parameter tests
client/main.c | 5 ++ doc/functional-bearer.rst | 43 ++++++++++++ doc/mgmt-protocol.rst | 8 ++- doc/org.bluez.Bearer.LE.rst | 38 ++++++++++ src/adapter.c | 12 ++++ src/bearer.c | 122 +++++++++++++++++++++++++++++++++ src/bearer.h | 3 + src/device.c | 8 +++ src/device.h | 3 + test/functional/test_bearer.py | 78 +++++++++++++++++++++ 10 files changed, 319 insertions(+), 1 deletion(-)
base-commit: 14bd6ab65f4a647302edbd6df27f6faa91bee8a8
Signature · 1 line
2.54.0 (Apple Git-157)