Skip to content

qdev: Typed array properties for better QOM introspection

Markus Armbruster qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 2 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* PATCH 3: Update tests/qtest/qmp-cmd-test.c

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qdev: Convert array properties to QAPI-aware registrationhw/core/qdev-prop-internal.h hw/core/qdev-properties-system.c hw/core/qdev-properties.c +4 more+85 -360 replies
2/3qdev: Remove unused DEFINE_PROP_ARRAY parameter _arraytypehw/display/apple-gfx-mmio.m hw/display/apple-gfx-pci.m hw/input/stellaris_gamepad.c +14 more+25 -310 replies
3/3qapi/qom: Make @qapi-type mandatory in output of qom-list etc.qapi/qom.json tests/qtest/qmp-cmd-test.c+5 -140 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMarc-André Lureau
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] qdev: Typed array properties for better QOM introspection

In my "[PATCH v8 RESEND 00/56] qom/qdev: associate properties with QAPI schema types", I noted under "Changes in v8":

* Drop typed array PropertyInfos

Why? They complicate matters, and I ran out of time.

This series brings them back. It's an updated version of PATCH 59+60 and a small part of PATCH 61 from Marc-André's v7. I managed to do without the QAPI generator changes from v7's PATCH 07+09.

With this applied, @qapi-type is always present, and the QAPI schema reflects that.

Based-on: <[email protected]>

v3:
* PATCH 3: Update tests/qtest/qmp-cmd-test.c

v2:
* PATCH 1: Fix qdev_prop_link_array.qapi_type, expand tabs (Marc-André)
* PATCH 3: New

Marc-André Lureau (2):
qdev: Convert array properties to QAPI-aware registration
qdev: Remove unused DEFINE_PROP_ARRAY parameter _arraytype

Markus Armbruster (1):
qapi/qom: Make @qapi-type mandatory in output of qom-list etc.

 qapi/qom.json                            | 10 ++--
 hw/core/qdev-prop-internal.h             | 19 +++++++
 hw/display/apple-gfx.h                   |  1 +
 include/hw/block/block.h                 |  2 +-
 include/hw/core/qdev-properties-system.h |  2 +
 include/hw/core/qdev-properties.h        | 37 +++++++-------
 hw/core/qdev-properties-system.c         |  6 +++
 hw/core/qdev-properties.c                | 64 ++++++++++++++----------
 hw/input/stellaris_gamepad.c             |  2 +-
 hw/intc/arm_gicv3_common.c               |  2 +-
 hw/intc/arm_gicv5_common.c               |  4 +-
 hw/intc/rx_icu.c                         |  4 +-
 hw/misc/arm_sysctl.c                     |  4 +-
 hw/misc/mps2-scc.c                       |  2 +-
 hw/net/rocker/rocker.c                   |  2 +-
 hw/net/virtio-net.c                      |  2 +-
 hw/nvram/xlnx-efuse.c                    |  2 +-
 hw/nvram/xlnx-versal-efuse-ctrl.c        |  2 +-
 hw/riscv/riscv_hart.c                    |  6 +--
 hw/virtio/virtio-iommu-pci.c             |  2 +-
 tests/qtest/qmp-cmd-test.c               |  9 +---
 tests/unit/test-qdev.c                   |  2 +-
 hw/display/apple-gfx-mmio.m              |  2 +-
 hw/display/apple-gfx-pci.m               |  2 +-
 hw/display/apple-gfx.m                   |  6 +++
 25 files changed, 115 insertions(+), 81 deletions(-)
Signature · 1 line
2.55.0