Skip to content

spdx30: Fix two bugs in the source download enrichment

Stefano Tondo openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3spdx30: Make source download enrichment part of the task signaturemeta/lib/oe/spdx30_tasks.py+4 -40 replies
2/3spdx30: Enrich gitsm source downloads like git onesmeta/lib/oe/spdx30_tasks.py+1 -10 replies
3/3oeqa/selftest: Add tests for source download enrichmentmeta/lib/oeqa/selftest/cases/spdx.py+47 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] spdx30: Fix two bugs in the source download enrichment

Two fixes for the source download enrichment added in 9f1825e74d ("spdx30: Add Git version and PURL to source downloads"):

- _enrich_source_package() and _generate_git_purl() start with an underscore, so bitbake leaves them out of the do_create_spdx signature, and SPDX_GIT_PURL_MAPPINGS with them. Changing the mappings restored the previous SPDX from sstate.

- gitsm downloads got no version and no PURL, because only fd.type "git" was handled.

Patch 1 changes the do_create_spdx signature of every recipe once.

Patch 3 adds one selftest per fix. Each fails on master without its fix. With the series, all SPDX30Check selftests pass.

Stefano Tondo (3):
spdx30: Make source download enrichment part of the task signature
spdx30: Enrich gitsm source downloads like git ones oeqa/selftest: Add tests for source download enrichment

 meta/lib/oe/spdx30_tasks.py          | 10 +++---
 meta/lib/oeqa/selftest/cases/spdx.py | 47 ++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+), 5 deletions(-)
Signature · 1 line
2.56.0