Skip to content

arm64: dts: qcom: sm8350: Add the inline crypto engine

Demeter Barna b4-sent linux-arm-msm linux-crypto linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20261105-b4-sm8350-ice-efad45e93262

Versions newest first

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- dt-bindings: drop SM8350 from the legacy single-clock list. It was
added there by mistake; SM8350 does not need the exemption, its node
has both clocks and the power domain.
- Link to v1: https://patch.msgid.link/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: crypto: qcom,inline-crypto-engine: Add SM8350Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml+1 -01 reply
2/2arm64: dts: qcom: sm8350: Add the inline crypto enginearch/arm64/boot/dts/qcom/sm8350.dtsi+13 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiAbel Vesa
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] arm64: dts: qcom: sm8350: Add the inline crypto engine

SM8350 has an inline crypto engine (ICE v3.2.0) next to its UFS host, but sm8350.dtsi does not describe it, so ufs-qcom runs without inline encryption. Add the compatible to the binding and the node to sm8350.dtsi, as on SM8450.

The region covers the engine (0x1d88000, 0x8000) and its key manager (0x1d90000, 0x9000), as in Qualcomm's SM8350 device tree; the clocks and the power domain are those of SM8450. The TrustZone offers the raw-key SCM calls but not GENERATE/PREPARE/IMPORT_ICE_KEY, so qcom-ice uses raw keys.

Tested on a Razer Edge 5G with fscrypt v2 on ext4: "AES-256-XTS using blk-crypto (native)", and files written with and without inlinecrypt read back correctly either way. dtbs_check is clean for all SM8350 boards.

Signed-off-by Demeter Barna <[email protected]>

---
Changes in v2:
- dt-bindings: drop SM8350 from the legacy single-clock list. It was
added there by mistake; SM8350 does not need the exemption, its node
has both clocks and the power domain.
- Link to v1: https://patch.msgid.link/[email protected]

---
Demeter Barna (2):
dt-bindings: crypto: qcom,inline-crypto-engine: Add SM8350
arm64: dts: qcom: sm8350: Add the inline crypto engine

 .../bindings/crypto/qcom,inline-crypto-engine.yaml          |  1 +
 arch/arm64/boot/dts/qcom/sm8350.dtsi                        | 13 +++++++++++++
 2 files changed, 14 insertions(+)

---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261105-b4-sm8350-ice-efad45e93262

Best regards,

Signature · 1 line
Demeter Barna <[email protected]>

Read the cover letter in its thread