Skip to content

i2c: omap: add support for DMA

Antoni Pokusinski dri-devel linux-devicetree linux-i2c linux-media linux-omap lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v24 patches 1 replySuperseded
  3. v13 patches 1 replySuperseded

Changes in v3 from the cover letter

* dropped patch "i2c: omap: remove unused is_rdr and is_xdr function arguments"
* added omap_i2c_disable/enable_pio_irqs() helper functions
* probe: added if (omap->dma) before the DMA free
* xfer_data: signal DMA completion in the case of NACK interrupt
* complete_cmd: signal DMA completion in the case of bus error (e.g. AL)
* xfer_msg: removed incorrect checks if (!omap->cmd_err)
* xfer_msg: added handling of DMA/IRQ cleanup in the b_hw && stop path

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: i2c: ti,omap4-i2c: Add DMA propertiesDocumentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml+12 -00 replies
2/3ARM: dts: am33xx-l4: Add missing DMAs for I2C controllersarch/arm/boot/dts/ti/omap/am33xx-l4.dtsi+4 -00 replies
3/3i2c: omap: add DMA supportdrivers/i2c/busses/i2c-omap.c+352 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] i2c: omap: add support for DMA

Hello,
This patchset introduces support for the TX & RX DMA transfers in the am335x/omap I2C controller. I tested this implementation on AM335x (Beaglebone Black) and things seem to work fine.

Kind regards,
Antoni Pokusinski

---
Changes since v2:
* dropped patch "i2c: omap: remove unused is_rdr and is_xdr function arguments"
* added omap_i2c_disable/enable_pio_irqs() helper functions
* probe: added if (omap->dma) before the DMA free
* xfer_data: signal DMA completion in the case of NACK interrupt
* complete_cmd: signal DMA completion in the case of bus error (e.g. AL)
* xfer_msg: removed incorrect checks if (!omap->cmd_err)
* xfer_msg: added handling of DMA/IRQ cleanup in the b_hw && stop path

Changes since v1:
* new patch "i2c: omap: remove unused is_rdr and is_xdr ..."
* probe: added goto err_dma_free instead of return in the case of failed i2c_add_numbered_adapter()
* changes in XRDY/RRDY, XDR/RDR interrupts management:
- init: do not enable the above-mentioned intrerupts
- xfer_msg: enable the interrupts before any non-DMA transfer
- xfer_msg: disable the interrupts after any non-DMA transfer
* xfer_msg: added checks on omap->cmd_err to catch NACK or AL error occured during DMA transfers
* general: moved scheme-related macros to the top of the file

Antoni Pokusinski (3):
dt-bindings: i2c: ti,omap4-i2c: Add DMA properties
ARM: dts: am33xx-l4: Add missing DMAs for I2C controllers
i2c: omap: add DMA support

 .../devicetree/bindings/i2c/ti,omap4-i2c.yaml |  12 +
 arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi      |   4 +
 drivers/i2c/busses/i2c-omap.c                 | 373 +++++++++++++++++-
 3 files changed, 368 insertions(+), 21 deletions(-)
Signature · 1 line
2.56.1