Skip to content

media: rockchip: rkcif: ENUM_FMT and bytesperline fixes

Faizel K B linux-arm-kernel linux-media linux-rockchip lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1: don't filter the DVP output formats, which have no media bus code (Mehdi)
- Patch 2: handle all planes and the DVP interface, and limit the stride to the line width register of each interface (Michael)
- Patch 2: drop "on MIPI" from the subject

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: rockchip: rkcif: Filter enumerated formats by media bus codedrivers/media/platform/rockchip/rkcif/rkcif-stream.c+14 -40 replies
2/2media: rockchip: rkcif: Honour the requested bytesperlinedrivers/media/platform/rockchip/rkcif/rkcif-capture-dvp.c drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c drivers/media/platform/rockchip/rkcif/rkcif-common.h +1 more+54 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] media: rockchip: rkcif: ENUM_FMT and bytesperline fixes

Two fixes for rkcif capture.

Patch 1 filters VIDIOC_ENUM_FMT by the media bus code, as the video devices set V4L2_CAP_IO_MC.

Patch 2 aligns bytesperline to 8 bytes and honours a larger value requested by userspace, so DMA-BUF importers that need a larger stride alignment can use the buffers directly.

Tested on RK3588 (Radxa ROCK 5B+) with an IMX415 sensor, using libcamera with the GPU software ISP. The DVP part is compile-tested only.

Changes in v2:
- Patch 1: don't filter the DVP output formats, which have no media bus code (Mehdi)
- Patch 2: handle all planes and the DVP interface, and limit the stride to the line width register of each interface (Michael)
- Patch 2: drop "on MIPI" from the subject

v1: https://lore.kernel.org/linux-media/[email protected]

Faizel K B (2):
media: rockchip: rkcif: Filter enumerated formats by media bus code
media: rockchip: rkcif: Honour the requested bytesperline

 .../rockchip/rkcif/rkcif-capture-dvp.c        |  4 ++
 .../rockchip/rkcif/rkcif-capture-mipi.c       |  3 +
 .../platform/rockchip/rkcif/rkcif-common.h    |  1 +
 .../platform/rockchip/rkcif/rkcif-stream.c    | 66 +++++++++++++++++--
 4 files changed, 68 insertions(+), 6 deletions(-)

base-commit: 7969a6f407cf55b5254c824c87875452655ef11e

Signature · 1 line
2.43.0