nvme: fabrics and target fixes
Status from this message: Thanks, applied to nvme-7.4.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v3 from the cover letter
- rework the nvme-auth fix to a per-queue counter (Keith Busch), drop the now unused shared field, and add the Fixes tag (sashiko); the Reviewed-by on v2 covered the atomic_t variant and is dropped
- resend the unchanged nvme-fc patch, still awaiting review
- drop the reconnect_delay patch (superseded), the GFP_KERNEL patch (applied) and the tbkas patch (applied)
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nvme-fc: fix use-after-free in nvme_fc_match_disconn_ls()drivers/ | +12 | 1 reply | |
| 2/2 | nvme-auth: fix data race on ctrl->transactiondrivers/ drivers/ | +1 | 6 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] nvme: fabrics and target fixes
Two remaining fixes from the previous rounds of this series:
- a use-after-free in nvme_fc_match_disconn_ls(): no iterator is sound across the rport lock drop inside the loop, so the loop is reworked to run entirely under the rport lock and to take a reference only for the match; reproduced under KASAN through fcloop
- a data race on the shared authentication transaction counter, reworked per review to a per-queue counter, dropping the shared ctrl->transaction field entirely
The other three patches from v2 are already resolved: the GFP_KERNEL persistent reservation change and the tbkas configfs locking are in nvme-7.4 now, and the reconnect_delay fix was superseded by an earlier identical patch posted by someone else.
Both patches are verified on an initiator/target VM pair: the fc loop is compile tested and exercised under KASAN through fcloop with six controllers on one remote port across tbkas force-reconnect cycles and concurrent disconnects with no reports; the DH-HMAC-CHAP authenticated session including I/O covers the auth path.
Changes since v2:
- rework the nvme-auth fix to a per-queue counter (Keith Busch), drop the now unused shared field, and add the Fixes tag (sashiko); the Reviewed-by on v2 covered the atomic_t variant and is dropped
- resend the unchanged nvme-fc patch, still awaiting review
- drop the reconnect_delay patch (superseded), the GFP_KERNEL patch (applied) and the tbkas patch (applied)
Guixin Liu (2):
nvme-fc: fix use-after-free in nvme_fc_match_disconn_ls()
nvme-auth: fix data race on ctrl->transaction
drivers/nvme/host/auth.c | 3 +-- drivers/nvme/host/fc.c | 22 ++++++++++++---------- drivers/nvme/host/nvme.h | 1 - 3 files changed, 13 insertions(+), 13 deletions(-)
Signature · 1 line
2.43.7