Skip to content

ASoC: dwc: Fix several issues in the I2S driver

[email protected] linux-sound lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyIn review
  2. v26 patches 2 repliesSuperseded
  3. v15 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- Add a Fixes tag to "ASoC: dwc: Fix DMA fifo_size calculation", as suggested by Sashiko.
- Ensure the reset is asserted when IRQ lookup fails, as suggested by Sashiko.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ASoC: dwc: Fix bit clock rate in TDM modesound/soc/dwc/dwc-i2s.c+3 -00 replies
2/6ASoC: dwc: Fix error handling in dw_i2s_set_fmt()sound/soc/dwc/dwc-i2s.c+6 -160 replies
3/6ASoC: dwc: Fix channels_max derived from COMP_PARAM_1sound/soc/dwc/dwc-i2s.c+2 -20 replies
4/6ASoC: dwc: Fix DMA fifo_size calculationsound/soc/dwc/dwc-i2s.c+4 -40 replies
5/6ASoC: dwc: Propagate optional IRQ lookup errorssound/soc/dwc/dwc-i2s.c+4 -20 replies
6/6ASoC: dwc: Remove redundant error messagessound/soc/dwc/dwc-i2s.c+6 -100 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchMaxim Kochetkov
1/6R-b
2/6R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] ASoC: dwc: Fix several issues in the I2S driver

From: bui duc phuc <[email protected]>

Hi all,

This series addresses several issues in the DesignWare I2S driver, including clock rate calculation, DAI configuration, channel limits, DMA FIFO sizing, and error handling.

Changes in v2:
- Move the indentation and typo fixes into a separate commit.
- Add a separate patch to propagate optional IRQ lookup errors.
- Add Maxim Kochetkov's Reviewed-by tag.

Changes in v3:
- Add a Fixes tag to "ASoC: dwc: Fix DMA fifo_size calculation", as suggested by Sashiko.
- Ensure the reset is asserted when IRQ lookup fails, as suggested by Sashiko.

Link v1:
https://lore.kernel.org/all/[email protected]/

Link v2:
https://lore.kernel.org/all/[email protected]/

Compile-tested only.

Best regards,
Phuc

bui duc phuc (6):
ASoC: dwc: Fix bit clock rate in TDM mode
ASoC: dwc: Fix error handling in dw_i2s_set_fmt()
ASoC: dwc: Fix channels_max derived from COMP_PARAM_1
ASoC: dwc: Fix DMA fifo_size calculation
ASoC: dwc: Propagate optional IRQ lookup errors
ASoC: dwc: Remove redundant error messages

 sound/soc/dwc/dwc-i2s.c | 59 +++++++++++++++++------------------------
 1 file changed, 25 insertions(+), 34 deletions(-)
Signature · 1 line
2.43.0