Skip to content

net: annotate data-races around sysctl knobs

Jiayuan Chen linux-rdma linux-s390 lkml mptcp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review
  2. v114 patches 18 repliesSuperseded

Changes in v2 from the cover letter

- only resend the patches that got a Reviewed-by or Acked-by, with the tags picked up; they are unchanged
- netfilter patches are moved to a separate series for nf-next (Simon)
- calipso is sent separately as a fix
- the other patches had no review yet and are left out for now
v1: https://lore.kernel.org/netdev/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5inet: frags: annotate data-races around fqdir->timeout and fqdir->max_distnet/ipv4/inet_fragment.c net/ipv4/ip_fragment.c+4 -40 replies
2/5ipv6: annotate data-races around icmpv6 reply sysctlsinclude/net/ipv6.h net/ipv6/icmp.c+6 -60 replies
3/5mptcp: annotate data-races around pernet sysctlsnet/mptcp/ctrl.c+9 -90 replies
4/5rds: annotate data-races around core rds sysctlsnet/rds/recv.c net/rds/send.c net/rds/threads.c+7 -70 replies
5/5net/smc: annotate data-races around smc sysctlsnet/smc/af_smc.c net/smc/smc_clc.c net/smc/smc_core.c +1 more+10 -101 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSimon HormanMatthieu Baerts (NGI0)Dust LiSidraya Jayagond
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH net-next v2 0/5] net: annotate data-races around sysctl knobs

This series annotates data races around a few sysctl knobs under net/. They are read without any lock while their handlers update them with WRITE_ONCE(), so add READ_ONCE() to the readers, and WRITE_ONCE() to the handlers and netlink paths that store to the same fields with plain writes.

There are no Fixes tags. Done one knob per patch this would be well over a hundred commits, so I grouped them by subsystem and feature instead to keep the review manageable. If maintainers prefer, I can split it up further with a Fixes tag on each one, as several smaller series.

No functional change.

v2:
- only resend the patches that got a Reviewed-by or Acked-by, with the tags picked up; they are unchanged
- netfilter patches are moved to a separate series for nf-next (Simon)
- calipso is sent separately as a fix
- the other patches had no review yet and are left out for now
v1: https://lore.kernel.org/netdev/[email protected]/

Jiayuan Chen (5):
inet: frags: annotate data-races around fqdir->timeout and

    fqdir->max_dist

ipv6: annotate data-races around icmpv6 reply sysctls
mptcp: annotate data-races around pernet sysctls
rds: annotate data-races around core rds sysctls net/smc: annotate data-races around smc sysctls

 include/net/ipv6.h       |  2 +-
 net/ipv4/inet_fragment.c |  2 +-
 net/ipv4/ip_fragment.c   |  6 +++---
 net/ipv6/icmp.c          | 10 +++++-----
 net/mptcp/ctrl.c         | 18 +++++++++---------
 net/rds/recv.c           |  2 +-
 net/rds/send.c           |  8 ++++----
 net/rds/threads.c        |  4 ++--
 net/smc/af_smc.c         |  8 ++++----
 net/smc/smc_clc.c        |  8 ++++----
 net/smc/smc_core.c       |  2 +-
 net/smc/smc_tx.c         |  2 +-
 12 files changed, 36 insertions(+), 36 deletions(-)
Signature · 1 line
2.43.0