Skip to content

Update handling of min and max channel in DisCo

Charles Keepax linux-sound lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 4 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Moved the parsing of min/max channels to only be processed if num_channels is missing

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2soundwire: Improve channel min/max commentsinclude/linux/soundwire/sdw.h+2 -20 replies
2/2soundwire: Assume default maximum valid channel if not specifieddrivers/soundwire/mipi_disco.c+8 -60 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierre-Louis Bossart
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Update handling of min and max channel in DisCo

The DisCo properties "mipi-sdw-min-channel-number" and "mipi-sdw-max-channel-number" are both channel indexes rather than counts. Update the kernel code to more accurately reflect this.

There are a few Qualcomm drivers that likely specify these incorrect, min_ch=1, max_ch=X, rather than min_ch=0, max_ch=X-1, however these should work fine as the number of supported channels is equivalent. If people feel strongly I can send another series to fix those up.

Changes since v2:
- Moved the parsing of min/max channels to only be processed if num_channels is missing

Changes since v1:
- Update wording on min_ch/max_ch comments

Charles Keepax (2):
soundwire: Improve channel min/max comments
soundwire: Assume default maximum valid channel if not specified

 drivers/soundwire/mipi_disco.c | 14 ++++++++------
 include/linux/soundwire/sdw.h  |  4 ++--
 2 files changed, 10 insertions(+), 8 deletions(-)
Signature · 1 line
2.47.3