Skip to content

Add Nuvoton MA35D1 keypad controller support

Feng-Yi Hsueh linux-arm-kernel linux-devicetree linux-input lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- dt-bindings: add optional resets and reference input.yaml.
- dt-bindings: fix interrupt, clock, and keymap formatting.
- input: use guard(mutex) in suspend/resume callbacks.
- input: rename error variables from ret to error and explicitly return 0 on successful resume.
- input: remove the unnecessary linux/mod_devicetable.h include.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: input: Add Nuvoton MA35D1 keypad controllerDocumentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml+75 -01 reply
2/2Input: keyboard: Add Nuvoton MA35D1 keypad driverdrivers/input/keyboard/Kconfig drivers/input/keyboard/Makefile drivers/input/keyboard/ma35d1_keypad.c+419 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchConor Dooley
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Add Nuvoton MA35D1 keypad controller support

The Nuvoton MA35D1 SoC provides a hardware matrix keypad controller supporting up to eight rows and eight columns.

This series adds the Device Tree binding and input driver for key press/release events, clock management, and system suspend/resume support.

Tested on a Nuvoton MA35D1 board with a 4x1 keypad configuration and a 1 MHz KPI clock using evtest.

Feng-Yi Hsueh (2):
dt-bindings: input: Add Nuvoton MA35D1 keypad controller
Input: keyboard: Add Nuvoton MA35D1 keypad driver

---
Changes since v1:
- dt-bindings: add optional resets and reference input.yaml.
- dt-bindings: fix interrupt, clock, and keymap formatting.
- input: use guard(mutex) in suspend/resume callbacks.
- input: rename error variables from ret to error and explicitly return 0 on successful resume.
- input: remove the unnecessary linux/mod_devicetable.h include.

 .../bindings/input/nuvoton,ma35d1-keypad.yaml |  75 ++++
 drivers/input/keyboard/Kconfig                |  11 +
 drivers/input/keyboard/Makefile               |   1 +
 drivers/input/keyboard/ma35d1_keypad.c        | 407 ++++++++++++++++++
 4 files changed, 494 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
 create mode 100644 drivers/input/keyboard/ma35d1_keypad.c
Signature · 1 line
2.43.0