Skip to content

i2c: mt7621: add Airoha AN7589 support

John Crispin linux-arm-kernel linux-devicetree linux-i2c linux-mediatek lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v2 posting 2/23 patches 2 repliesSuperseded
  3. v2 posting 1/23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v3 from the cover letter

- Patch 1: add the Reviewed-by of Philipp.
- Patch 2: add the Acked-by of Conor.
- Patch 3: compute the AN7589 divider with constant limits, so a clock rate below 1 MHz cannot wrap it (kernel test robot, sashiko).
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3i2c: mt7621: assert and deassert the reset linedrivers/i2c/busses/i2c-mt7621.c+9 -10 replies
2/3dt-bindings: i2c: mt7621: add Airoha AN7589Documentation/devicetree/bindings/i2c/mediatek,mt7621-i2c.yaml+9 -10 replies
3/3i2c: mt7621: add support for Airoha AN7589drivers/i2c/busses/i2c-mt7621.c+52 -80 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPhilipp ZabelConor Dooley
1/3R-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] i2c: mt7621: add Airoha AN7589 support

The Airoha AN7589 carries the MT7621 I2C controller with a second control register that holds a 16 bit clock divider. It runs without SCL stretching.

Patch 1 resets the controller with reset_control_assert() and reset_control_deassert() instead of device_reset(), as the EN7581 and AN7589 reset controller has no .reset operation. Patch 2 adds the compatible, with mediatek,mt7621-i2c as the fallback. Patch 3 describes the variants as match data and uses the wider divider for bus rates down to about 3 kHz.

The series applies to next-20261105 and has no dependencies.

Changes in v3:
- Patch 1: add the Reviewed-by of Philipp.
- Patch 2: add the Acked-by of Conor.
- Patch 3: compute the AN7589 divider with constant limits, so a clock rate below 1 MHz cannot wrap it (kernel test robot, sashiko).
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Add patch 1. It replaces "clk: en7523: add a reset operation" from the clk series, as Philipp suggested.
- Patch 2: add mediatek,mt7621-i2c as the fallback compatible (Conor).
- Patch 3: the extended divider supports bus rates down to about 3 kHz. Set it up before the controller is enabled.
- Link to v1: https://lore.kernel.org/r/[email protected]

John Crispin (3):
i2c: mt7621: assert and deassert the reset line
dt-bindings: i2c: mt7621: add Airoha AN7589
i2c: mt7621: add support for Airoha AN7589

 .../bindings/i2c/mediatek,mt7621-i2c.yaml     | 10 ++-
 drivers/i2c/busses/i2c-mt7621.c               | 70 ++++++++++++++++---
 2 files changed, 70 insertions(+), 10 deletions(-)

base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b

Signature · 1 line
2.34.1