Skip to content

RFC wifi: b43: core revision 40 and 42 MAC setup (series 2/4)

Andreas Wendleder b43-dev linux-wireless lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wifi: b43: set the DMA burst and prefetch bits of core revisions 40 and 42drivers/net/wireless/broadcom/b43/b43.h drivers/net/wireless/broadcom/b43/dma.c drivers/net/wireless/broadcom/b43/dma.h+12 -00 replies
2/3wifi: b43: MAC core setup for core revisions 40 and 42drivers/net/wireless/broadcom/b43/b43.h drivers/net/wireless/broadcom/b43/main.c+108 -10 replies
3/3wifi: b43: address match table, templates and beacons for the AC microcodedrivers/net/wireless/broadcom/b43/main.c+126 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC wireless-next 0/3] wifi: b43: core revision 40 and 42 MAC setup (series 2/4)

MAC core support for the BCM4352/BCM4360 core revisions 40 and 42. Things that depend on the core revision are gated on it (b43_is_ac_core()), things that depend on the microcode layout are gated on the microcode revision (b43_ucode_is_ac(), revision 784 and above, set once the microcode is loaded). The TX and RX formats and the PHY are not in this series. Based on series 1/4.

This is posted as RFC so that people with these chips can use and test it now; b43 is orphaned and nobody is set to take these patches at the moment. Series 1/4 is on the list:
https://lore.kernel.org/linux-wireless/[email protected]/

Where the values come from: the register sequences and table contents were taken from Broadcom's wl driver running on this MacBook, by tracing its register accesses (bpftrace on wl's MMIO accessors), and reduced to what the hardware needs. Parts come from Alessio Ferri's AC-PHY work (the PHY init sequence, the 40 and 80 MHz coefficient tables, a TX gain table, the Farrow resampler formula, the VHT fields of the TX descriptor, register and table names), and some formats follow brcmsmac.
The result was tested on the hardware as described below.

Each patch compiles on its own (kernel 7.2.10 headers). The four series together were run on a MacBookAir6,1 (14e4:43a0, BCM4360, core revision 42, microcode 832.127, 2 of 3 chains wired) on top of v7.3-rc5's b43. The AC PHY only comes with series 4, so the earlier series cannot be exercised on this hardware alone.

Andreas Wendleder (3):
wifi: b43: set the DMA burst and prefetch bits of core revisions 40

    and 42

wifi: b43: MAC core setup for core revisions 40 and 42
wifi: b43: address match table, templates and beacons for the AC
microcode

 drivers/net/wireless/broadcom/b43/b43.h  |  14 ++
 drivers/net/wireless/broadcom/b43/dma.c  |   4 +
 drivers/net/wireless/broadcom/b43/dma.h  |   2 +
 drivers/net/wireless/broadcom/b43/main.c | 242 +++++++++++++++++++++--
 4 files changed, 246 insertions(+), 16 deletions(-)