Skip to content

fs: Various I_DIRTY_* state handling fixes

Jan Kara fuse-devel gfs2 linux-block linux-fscrypt linux-fsdevel linux-nfs linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 10 repliesIn review
  2. v113 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Fixed orangefs checking of inode dirtiness
* Added Reviewed-by & Acked-by tags
* Added Fixes tags
* Made gfs2_fsync() conversion more bug-to-bug compatible

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13bdev: Drop pointless loop from blkdev_flush_mapping()block/bdev.c+6 -191 reply
2/13xfs: Drop pointless I_DIRTY_PAGES check in xfs_can_free_cowblocks()fs/xfs/xfs_reflink.h+1 -21 reply
3/13orangefs: Check PAGECACHE_TAG_DIRTY instead of I_DIRTY_PAGES inode statefs/orangefs/orangefs-utils.c+17 -30 replies
4/13fs: Provide inode_is_dirty() helperinclude/linux/fs.h+11 -00 replies
5/13jfs: Use inode_is_dirty() in jfs_fsync()fs/jfs/file.c+1 -20 replies
6/13gfs2: Avoid racy dirtiness check in gfs2_fsync()fs/gfs2/file.c+3 -74 replies
7/13fuse: Use inode_is_dirty() check in fuse_evict_inode()fs/fuse/inode.c+1 -10 replies
8/13fs: Provide inode_or_folios_dirty() helperinclude/linux/fs.h+7 -02 replies
9/13gfs2: Fix dirtiness checks in gfs2_write_inode() and evict_linked_inode()fs/gfs2/super.c+3 -21 reply
10/13afs: Use inode_or_folios_dirty() in afs_evict_inode()fs/afs/inode.c+2 -40 replies
11/13nfsd: Use inode_or_folios_dirty() for dirtiness check in wait_for_concurrent_writes()fs/nfsd/vfs.c+1 -10 replies
12/13fscrypt: Use inode_or_folios_dirty() instead of explicit state checkfs/crypto/keysetup.c+1 -10 replies
13/13fs: Use inode_or_folios_dirty() in __inode_lru_list_add()fs/inode.c+3 -10 replies

Reviews trailers per patch

5 of 13 patches have a Reviewed-by or Acked-by.

PatchCarlos MaiolinoJeff LaytonChuck LeverAndreas GruenbacherPankaj Raghav (Samsung)
1/13R-b
2/13R-b R-b
3/13
4/13
5/13
6/13R-b
7/13
8/13
9/13R-b
10/13
11/13R-b A-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/13] fs: Various I_DIRTY_* state handling fixes

Hello,

this series is a result of my audit of I_DIRTY_* state handling fixes. Over the years some pointless code or code with smaller or larger bugs has accumulated in filesystems around handling of inode dirty state. In particular testing for I_DIRTY_PAGES is very subtle (and racy without holding i_lock), some places forget that I_DIRTY_TIME also means inode has dirty metadata etc. So this patch set removes direct checks of dirtiness state from filesystems and either change them to directly testing PAGECACHE_TAG_DIRTY or to a helper function which performs appropriate dirtiness check reliably.

Changes since v1:
* Fixed orangefs checking of inode dirtiness
* Added Reviewed-by & Acked-by tags
* Added Fixes tags
* Made gfs2_fsync() conversion more bug-to-bug compatible

Honza
Previous versions: