Skip to content

ASoC: cs35l56: Series to stop writing ASP registers the driver doesn't own

Richard Fitzgerald linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: cs35l56: Only write ASP1TXn registers when widget is powered-upsound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c sound/soc/codecs/cs35l56.h+86 -310 replies
2/2ASoC: cs35l56: Fix unwanted writes to ASP config registersinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c+48 -430 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: cs35l56: Series to stop writing ASP registers the driver doesn't own

The driver was writing to the ASP registers on systems where it didn't own control of those registers. These two patches prevent that.

There is more detail in the commit messages of why this problem exists, but the summary is that these registers are usually owned by the firmware and/or a secondary (or tertiary) host using the I2C/SPI control interfaces.

Richard Fitzgerald (2):
ASoC: cs35l56: Only write ASP1TXn registers when widget is powered-up
ASoC: cs35l56: Fix unwanted writes to ASP config registers

 include/sound/cs35l56.h           |   2 +-
 sound/soc/codecs/cs35l56-shared.c |  38 +-------
 sound/soc/codecs/cs35l56.c        | 147 ++++++++++++++++++++++++------
 sound/soc/codecs/cs35l56.h        |   1 +
 4 files changed, 124 insertions(+), 64 deletions(-)
Signature · 1 line
2.47.3