Skip to content

tests/kms_colorop: reduce test run time

Alex Hung igt-dev 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- 2/3: Keep each colorop_group in static storage, as igt_subtest_f() returns through siglongjmp (Harry)
- 3/3: Create the probe fbs only after a primary plane supports the input format, so unsupported formats skip instead of failing, and clear the CRTC and writeback state after each probe (Harry)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests/kms_colorop: skip early when no pipeline fitstests/kms_colorop.c+8 -80 replies
2/3tests/kms_colorop: set up subtest groups on demandtests/kms_colorop.c+111 -1400 replies
3/3tests/kms_colorop: check writeback formats firsttests/kms_colorop.c+53 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] tests/kms_colorop: reduce test run time

kms_colorop spends most of its run time on setup and framebuffer accesses rather than on the color pipeline checks themselves. This is worst on hardware where CPU access to VRAM is slow, like DCN 3.0.

This series:
- skips subtests before touching any framebuffer when no color pipeline matches the requested colorops,
- sets up each subtest group on demand, so a process only pays for the groups whose subtests actually run,
- checks the writeback format list before creating probe framebuffers, and creates them once per connector instead of once per CRTC.

Run time of kms_colorop, before -> after:

DCN 3.5: 0m11.116s -> 0m7.401s
DCN 3.0: 3m32.316s -> 0m16.382s

Changes in v2:
- 2/3: Keep each colorop_group in static storage, as igt_subtest_f() returns through siglongjmp (Harry)
- 3/3: Create the probe fbs only after a primary plane supports the input format, so unsupported formats skip instead of failing, and clear the CRTC and writeback state after each probe (Harry)

Alex Hung (3):
tests/kms_colorop: skip early when no pipeline fits tests/kms_colorop: set up subtest groups on demand tests/kms_colorop: check writeback formats first

 tests/kms_colorop.c | 349 ++++++++++++++++++++++----------------------
 1 file changed, 171 insertions(+), 178 deletions(-)
Signature · 1 line
2.53.0