Skip to content

staging: sm750fb: Clean up helpers and fix DAC power-off handling

Ali Köse linux-fbdev linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: sm750fb: Replace set_DAC macro with a static functiondrivers/staging/sm750fb/ddk750_display.c drivers/staging/sm750fb/ddk750_power.h+7 -60 replies
2/3staging: sm750fb: Fix DAC power-off bit handlingdrivers/staging/sm750fb/ddk750_display.c+2 -10 replies
3/3staging: sm750fb: Remove empty software I2C acknowledgement helperdrivers/staging/sm750fb/ddk750_swi2c.c+2 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] staging: sm750fb: Clean up helpers and fix DAC power-off handling

This series replaces the set_DAC macro with a local static function, corrects the DAC power-off bit handling, and removes an empty software I2C acknowledgement helper and its ineffective parameter.

The first and third patches preserve existing behavior. The second patch maps the extracted 0/1 DAC state to bit 20 rather than OR-ing it into bit 0 of MISC_CTRL.

Based on staging-next at 6628e7d4c6b (Linux 7.4-rc1).

Validation:
- All SM750 driver objects compiled and linked into sm750fb.o with W=1, CONFIG_FB=y, CONFIG_STAGING=y, and CONFIG_FB_SM750=m.
- A standalone mocked-register test checked 72 DAC state and register preservation cases: 36 failed before the fix and none failed afterward.
- checkpatch.pl reported no errors or warnings.
- git diff --check passed.

Hardware testing was not performed.

Ali Köse (3):
staging: sm750fb: Replace set_DAC macro with a static function
staging: sm750fb: Fix DAC power-off bit handling
staging: sm750fb: Remove empty software I2C acknowledgement helper

 drivers/staging/sm750fb/ddk750_display.c |  9 ++++++++-
 drivers/staging/sm750fb/ddk750_power.h   |  5 -----
 drivers/staging/sm750fb/ddk750_swi2c.c   | 19 ++-----------------
 3 files changed, 10 insertions(+), 23 deletions(-)

base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4

Signature · 1 line
2.53.0